Skip to content

ec2_vol: Fix iops setting and enforce iops/throughput parameters usage - #371

Merged
ansible-zuul[bot] merged 4 commits into
ansible-collections:mainfrom
markuman:fix_ec2_vol
Jun 2, 2021
Merged

ec2_vol: Fix iops setting and enforce iops/throughput parameters usage#371
ansible-zuul[bot] merged 4 commits into
ansible-collections:mainfrom
markuman:fix_ec2_vol

Conversation

@markuman

Copy link
Copy Markdown
Member
SUMMARY

ec2_vol: Fix iops setting and enforce iops/throughput parameters usage
Adopted PR: #334
Fixes: #330

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuman Thank you very much for working on this. I left some minor suggestions.

Comment thread plugins/modules/ec2_vol.py
Comment thread plugins/modules/ec2_vol.py
Comment thread plugins/modules/ec2_vol.py
@alinabuzachis
alinabuzachis self-requested a review May 21, 2021 10:10
@ansibullbot

Copy link
Copy Markdown

@goneri

goneri commented May 25, 2021

Copy link
Copy Markdown
Member

recheck

1 similar comment
@goneri

goneri commented May 25, 2021

Copy link
Copy Markdown
Member

recheck

@alinabuzachis
alinabuzachis requested a review from jillr May 26, 2021 10:28
@goneri
goneri requested a review from tremble June 1, 2021 14:37

@jillr jillr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @markuman!

@jillr jillr added the gate label Jun 2, 2021
@ansible-zuul
ansible-zuul Bot merged commit 7330a29 into ansible-collections:main Jun 2, 2021
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Aug 27, 2021
ansible-zuul Bot pushed a commit that referenced this pull request Sep 9, 2021
#371) (#479)

ec2_vol: backport to stable-1.5 to fix modify_volume size option bug

SUMMARY

Back port to stable-1.5 to fix a bug in  modify_volume, 'size' option.

Fixes #471.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vol
ADDITIONAL INFORMATION



Required fix was done but was not applied in 1.5.0 release.
For more details, please visit #471.

Backports: #371
Depends-On: #491

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ollections#371)

* Fix passing an instance profile arn to ec2_launch_template

If the string given on the iam_instance_profile looked like an arn, the
wrong structure format was being returned. boto3 expects a dict of the
format { arn: "{{ arn }}" } but the string was returned instead.

This fixes this error:
Couldn't create subsequent launch template version: Parameter validation failed:
Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'>


* integration test
* changelog
Co-authored-by: Mark Chappell <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ollections#371)

* Fix passing an instance profile arn to ec2_launch_template

If the string given on the iam_instance_profile looked like an arn, the
wrong structure format was being returned. boto3 expects a dict of the
format { arn: "{{ arn }}" } but the string was returned instead.

This fixes this error:
Couldn't create subsequent launch template version: Parameter validation failed:
Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'>


* integration test
* changelog
Co-authored-by: Mark Chappell <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ollections#371)

* Fix passing an instance profile arn to ec2_launch_template

If the string given on the iam_instance_profile looked like an arn, the
wrong structure format was being returned. boto3 expects a dict of the
format { arn: "{{ arn }}" } but the string was returned instead.

This fixes this error:
Couldn't create subsequent launch template version: Parameter validation failed:
Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'>


* integration test
* changelog
Co-authored-by: Mark Chappell <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 18, 2024
…ollections#371)

* Fix passing an instance profile arn to ec2_launch_template

If the string given on the iam_instance_profile looked like an arn, the
wrong structure format was being returned. boto3 expects a dict of the
format { arn: "{{ arn }}" } but the string was returned instead.

This fixes this error:
Couldn't create subsequent launch template version: Parameter validation failed:
Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'>

* integration test
* changelog
Co-authored-by: Mark Chappell <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@b528eaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug community_review integration tests/integration module module plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ec2_vol sets all volumes with an iops field to be io1

6 participants