Skip to content

Improve state and config changes in ec2_instance - #370

Merged
ansible-zuul[bot] merged 2 commits into
ansible-collections:mainfrom
jillr:ec2_instance_state_handling
Jun 4, 2021
Merged

Improve state and config changes in ec2_instance#370
ansible-zuul[bot] merged 2 commits into
ansible-collections:mainfrom
jillr:ec2_instance_state_handling

Conversation

@jillr

@jillr jillr commented May 19, 2021 •
edited by goneri
Loading

Copy link
Copy Markdown
Contributor

Depends-On: ansible/ansible-zuul-jobs#915
Depends-On: #381

SUMMARY

This patch ensures that when changing state and/or supported parameters for an instance, changes are applied regardless of the starting or desired state of the instance.

Fixes: #380

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

@jillr jillr changed the title Improve state and config changes in ec2_instance [WIP] Improve state and config changes in ec2_instance May 19, 2021
@jillr

jillr commented May 19, 2021

Copy link
Copy Markdown
Contributor Author

WIP while we work out the zuul changes in the linked PR

@jillr

jillr commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@jillr

jillr commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@ansibullbot

ansibullbot commented May 21, 2021

Copy link
Copy Markdown

cc @ryansb @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels May 21, 2021
@jillr

jillr commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@jillr jillr changed the title [WIP] Improve state and config changes in ec2_instance Improve state and config changes in ec2_instance May 25, 2021
@jillr

jillr commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels May 25, 2021
@jillr
jillr force-pushed the ec2_instance_state_handling branch from 84f221c to 9fece09 Compare May 25, 2021 22:40
@jillr

jillr commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

recheck

2 similar comments
@jillr

jillr commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@goneri

goneri commented May 27, 2021

Copy link
Copy Markdown
Member

recheck

@jillr
jillr force-pushed the ec2_instance_state_handling branch from 1ea0e13 to b55fd6c Compare June 1, 2021 21:32
jillr added 2 commits June 1, 2021 14:33
@jillr
Improve state and config changes in ec2_instance
87e0646 
Fixes: community.aws/issues/16
This patch ensures that when changing state and/or supported parameters for
an instance, changes are applied regardless of the starting or desired state
of the instance.
@jillr
handle long resource_prefixes in role names
71cf248
@jillr
jillr force-pushed the ec2_instance_state_handling branch from b55fd6c to 71cf248 Compare June 1, 2021 21:33
@goneri

goneri commented Jun 2, 2021

Copy link
Copy Markdown
Member

recheck

1 similar comment
@jillr

jillr commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@jillr

jillr commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

The tests passed on my machine. ;) Different integration test failure each time the last two runs, and they look to be bog standard "sometimes ec2_instance times are a touch flaky". Will keep rechecking. Sanity tests are passing though!

@jillr

jillr commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

recheck

@jillr

jillr commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

ready_for_review

briantist
briantist approved these changes Jun 2, 2021
View reviewed changes

@briantist briantist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jillr thanks for this change! I was able to install the change locally but unfortunately my role has changed and I'm somewhat removed from the areas where this was being used, and I wasn't able to actually run it myself. I did look over the code though, and the tests you have look like they test the right thing! :)

I can't see the test results (are the tests in AWS collections run elsewhere?) but I assume they worked correctly. Thanks again!

@jillr

jillr commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @briantist! Shippable was discontinuted so we're using Zuul now. You have to click the "details" on ansible/check, then follow the link to the integration tests, then hit the console tab.
https://dashboard.zuul.ansible.com/t/ansible/build/c26062e028ee49bdb092ff3840ce6090/console

@briantist

briantist commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

Ah! Thank you, I see them now.

@jillr jillr added the gate label Jun 4, 2021
@ansible-zuul
ansible-zuul Bot merged commit 1e18f10 into ansible-collections:main Jun 4, 2021
@jillr jillr mentioned this pull request Jun 18, 2021
Merged
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@vijayanandsharma
Added 'worker_type' and 'glue_version' attributes to the module (ansi…
39c6a43 
…ble-collections#370)

* Added 'worker_type' and 'glue_version' attributes to the module
* fix: fixed compare_glue_job_params to compare the new attributes
* Added changelog - fragments
* Minor docs tweaks
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@vijayanandsharma @abikouo
Added 'worker_type' and 'glue_version' attributes to the module (ansi…
1915f2a 
…ble-collections#370)

* Added 'worker_type' and 'glue_version' attributes to the module
* fix: fixed compare_glue_job_params to compare the new attributes
* Added changelog - fragments
* Minor docs tweaks
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@vijayanandsharma
Added 'worker_type' and 'glue_version' attributes to the module (ansi…
04dc05f 
…ble-collections#370)

* Added 'worker_type' and 'glue_version' attributes to the module
* fix: fixed compare_glue_job_params to compare the new attributes
* Added changelog - fragments
* Minor docs tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gravesm gravesm gravesm approved these changes
+1 more reviewer
@briantist briantist briantist approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue/PR relates to a bug community_review integration tests/integration module module plugins plugin (any type) tests tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ec2_instance ignores some/all options depending on state option value and current actual state

5 participants

@jillr @ansibullbot @goneri @briantist @gravesm