Rework s3_bucket to use ErrorHandler model by tremble · Pull Request #2478 · ansible-collections/amazon.aws

tremble · 2025-01-21T11:37:42Z

SUMMARY

s3_bucket has some support for non-AWS "S3" APIs, this PR reworks s3_bucket module to more consistently handle the various Errors that get thrown when the non-AWS-S3 API doesn't cleanly support some of the more advanced S3 features.

Our testing for non-AWS APIs is near non-existent, so it's important that the patterns displayed in the module are easy to follow and cleanly handle things a feature not being supported if someone doesn't try to use it.

Also fixes idempotency when setting the simplistic "templated" ACLs.

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

I plan on migrating the remaining S3 modules in amazon.aws but this is just the first one.

github-actions · 2025-01-21T11:40:39Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2025-01-21T12:26:08Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3a6ab77570aa4d47bb4329bca9253819

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 10m 29s
✔️ ansible-test-splitter SUCCESS in 3m 55s
✔️ integration-amazon.aws-1 SUCCESS in 12m 54s
✔️ integration-amazon.aws-2 SUCCESS in 8m 17s
Skipped 42 jobs

softwarefactory-project-zuul · 2025-01-28T12:55:43Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/42712a44b1f8434ca7586e09503872df

✔️ ansible-galaxy-importer SUCCESS in 6m 29s
✔️ build-ansible-collection SUCCESS in 10m 21s
✔️ ansible-test-splitter SUCCESS in 4m 04s
✔️ integration-amazon.aws-1 SUCCESS in 13m 36s
✔️ integration-amazon.aws-2 SUCCESS in 8m 16s
Skipped 42 jobs

softwarefactory-project-zuul · 2025-01-28T13:41:20Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/amazon.aws for 2478,c14f9010e34318f17aaa9a0b375152fc043c2ba2

softwarefactory-project-zuul · 2025-01-28T14:10:00Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f7aa4f6300ee47328d0df2a667f4736a

✔️ ansible-galaxy-importer SUCCESS in 5m 37s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 12m 43s
✔️ integration-amazon.aws-2 SUCCESS in 8m 14s
Skipped 42 jobs

softwarefactory-project-zuul · 2025-01-28T14:34:49Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/07592f55781e497482048db8ece3560b

✔️ ansible-galaxy-importer SUCCESS in 4m 49s
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 13m 00s
✔️ integration-amazon.aws-2 SUCCESS in 7m 30s
Skipped 42 jobs

vdl-dsi-architecture · 2025-11-19T08:47:36Z

Can this be backported to 9.5.x?

tremble · 2025-11-19T09:00:54Z

Can this be backported to 9.5.x?

By default I wouldn't backport this to the 9 series. At this point, with 10 having been released, 9 is only receiving bugfixes. Is there a reason you need this backported?

vdl-dsi-architecture · 2025-11-19T09:10:10Z

Because we are stuck on ansible 2.16 for RHEL8 so we cannot switch to 10.x. We had to switch from minio to AIStor since minio doesn't provide support or releases for minio anymore. AIStor return NotSupported instead of NotImplemented for APIs they don't support and support is telling us that ansible's code is incorrect for relying on error.code instead of http status:

AWS S3 doesn't document them the way they return for various APIs - the clients are not supposed to rely on the error.Code what you need to ensure is enhance this to support both NotSupported and NotImplemented as they use it vice versa. Instead rely on the http_status_code which is 501 for all of them.

amazon.aws/plugins/modules/s3_bucket.py

Line 691 in a97284a

except is_boto3_error_code(["NotImplemented", "XNotImplemented"]) as e:

this is an incomplete code, this code needs to be fixed here.

amazon.aws/CHANGELOG.rst

Line 2395 in ccc09eb

- s3_bucket - Accept XNotImplemented response to support NetApp StorageGRID.

s3_bucket - Accept XNotImplemented response to support NetApp StorageGRID.
Just like how they added support for NetApp StorageGRID but instead of doing this the application must be fixed to use http_status_code instead since the ErrorCode is prone to change for example new S3 Express endpoints do not return NotImplemented anymore.

It looks like current Ansible code has already fixed this behavior. See

amazon.aws/plugins/modules/s3_bucket.py

Line 691 in ccc09eb

try:

.

tremble · 2025-11-19T10:24:05Z

Because we are stuck on ansible 2.16 for RHEL8 so we cannot switch to 10.x. We had to switch from minio to AIStor since minio doesn't provide support or releases for minio anymore.

The code to fix that was fairly invasive and doesn't really fit our backport policy.

However, it is still possible to install more recent versions of Ansible on RHEL8 using the python3.12 package and a virtual environment. Given that ansible-core 2.16 is no longer supported and won't receive bug or security fixes, this is the route I would recommend taking. While this is most commonly used for development (so you can install and test against multiple versions or Ansible and Python), it's also an effective way to run Ansible in general. See also: https://www.redhat.com/en/blog/python-venv-ansible

dnf install python3.12
python3.12 -m venv ~/ansible-venv
source ~/ansible-venv/bin/activate
pip install ansible
pip install boto3 botocore

When you want to run Ansible

source ~/ansible-venv/bin/activate
ansible-playbook ...

AIStor return NotSupported instead of NotImplemented for APIs they don't support and support is telling us that ansible's code is incorrect for relying on error.code instead of http status:

This is only half true. AWS themselves use NotImplemented and the API documentation states:

Amazon S3 error codes
...
Code: NotImplemented
Description: A header you provided implies functionality that is not implemented.
HTTP Status Code: 501 Not Implemented
SOAP Fault Code Prefix: Server

As such, we're well within the API specifications to support NotImplemented rather than than 501. We deliberately check the Codes not the HTTP status because Amazon's APIs often return many different error codes under the same http status. While, during the rewrite, the HTTP codes have now been added to help with cases like yours, this doesn't make what we're doing "wrong" it just means it doesn't work for some of the "clones", some of which we have never claimed to support, even if we've been open to making small changes to help folks like yourself.

I would also point to the error handling guide for the botocore library we depend on (from Amazon), which generally recommends testing the codes, with the HTTPStatusCode being provided to aid with debugging when you contact support rather than for error handling. In the example you've provided, I suspect the 501 is only being caught because no ErrorCode is being sent at all.

vdl-dsi-architecture · 2025-11-19T10:40:27Z

I expected this answer and understand full well it would be a very involved backport. Still felt it was worth asking.

To answer your message in more details:

However, it is still possible to install more recent versions of Ansible on RHEL8 using the python3.12 package and a virtual environment.

I understand this, it is indeed how we have ansible setup. I'm speaking specifically about how ansible > 2.16 cannot run basic function on RHEL8 nodes (like installing packages or modifying firewall rules).

I would also point to the error handling guide for the botocore library we depend on (from Amazon), which generally recommends testing the codes, with the HTTPStatusCode being provided to aid with debugging when you contact support rather than for error handling. In the example you've provided, I suspect the 501 is only being caught because no ErrorCode is being sent at all.

I agree that the Ansible implementation is pretty sane, this is the response from AIStor for GET /bucket?publicAccessBlock:

501 Not Implemented
X-Content-Type-Options: nosniff
X-Xss-Protection: 1; mode=block
Accept-Ranges: bytes
Content-Type: application/xml
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Amz-Id-2: db82ebe5d7b8ec6b2
Content-Length: 314
Server: MinIO Enterprise
Vary: Origin
X-Amz-Bucket-Region: eu-be-liege-1
X-Amz-Request-Id: 1878CFA

<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>NotSupported</Code><Message>This API is not supported by the server</Message><Resource>/nexus</Resource><Region>eu-be-liege-1</Region><RequestId>1878CFA</RequestId><HostId>db82ebe5d7b8ec6b2</HostId></Error>

and this is ansible's stack trace:

Traceback (most recent call last):
  File "/tmp/ansible_amazon.aws.s3_bucket_payload_mmi729wq/ansible_amazon.aws.s3_bucket_payload.zip/ansible_collections/amazon/aws/plugins/modules/s3_bucket.py", line 691, in handle_bucket_public_access_config
    current_public_access = get_bucket_public_access(s3_client, name)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/ansible_amazon.aws.s3_bucket_payload_mmi729wq/ansible_amazon.aws.s3_bucket_payload.zip/ansible_collections/amazon/aws/plugins/modules/s3_bucket.py", line 2079, in get_bucket_public_access
    bucket_public_access_block = s3_client.get_public_access_block(Bucket=bucket_name)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/ansible_amazon.aws.s3_bucket_payload_mmi729wq/ansible_amazon.aws.s3_bucket_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/retries.py", line 107, in deciding_wrapper
    return unwrapped(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pipenv/ansible-_ZyD9MGP/lib/python3.12/site-packages/botocore/client.py", line 601, in _api_call
    return self._make_api_call(operation_name, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pipenv/ansible-_ZyD9MGP/lib/python3.12/site-packages/botocore/context.py", line 123, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/pipenv/ansible-_ZyD9MGP/lib/python3.12/site-packages/botocore/client.py", line 1074, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (NotSupported) when calling the GetPublicAccessBlock operation: This API is not supported by the server

tremble · 2025-11-19T10:48:49Z

@vdl-dsi-architecture Have you tested this with amazon.aws 10 ? Looking at that exception, it might actually still fail, since there is an ErrorCode provided. For 10 and above, if this still doesn't work I'm certainly open to adding NotSupported to the list of error codes we handle.

marktheunissen · 2025-11-19T12:52:06Z

Hi @tremble, I just tested with amazon.aws 10 and see a similar exception, so yes it still fails.

AWS has started to return NotSupported as the value of error.Code, in S3 Express. AWS might not document these codes properly.

For example, in this list (https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html#ErrorCodeList) there is no mention of NotSupported, however we can see a random user of boto3 encountering this error on S3 Express here: boto/boto3#3972 An error occurred (NotSupported)....

Could the amazon.aws module rather rely on the 501 HTTP response, instead of the error.Code, which AWS might change again? We believe that the HTTP status code is a more reliable way to detect this issue. Otherwise the list continues to grow with XNotImplemented, NotImplemented, NotSupported, etc.

ramondeklein · 2025-11-19T13:30:28Z

Adding "NotSupported" to

amazon.aws/plugins/modules/s3_bucket.py

Line 691 in a97284a

except is_boto3_error_code(["NotImplemented", "XNotImplemented"]) as e:

will also fix the MinIO issue for Ansible. That might be a proper fix, when backporting is considered too invasive. I submitted #2765 that does exactly that.

Bumps the github-actions group with 7 updates: Package From To actions/checkout 4.3.1 7.0.1 actions/setup-python 5.6.0 7.0.0 actions/upload-artifact 4.6.2 7.0.1 ansible-community/ansible-test-gh-action 1.17.0 1.18.0 actions/github-script 7.1.0 9.0.0 dawidd6/action-download-artifact 16 21 SonarSource/sonarqube-scan-action 7.0.0 8.2.1 Updates actions/checkout from 4.3.1 to 7.0.1 Release notes Sourced from actions/checkout's releases. v7.0.1 What's Changed skip running unsafe pr check if input is default by @aiqiaoy in actions/checkout#2518 trim only ascii whitespace for branch by @aiqiaoy in actions/checkout#2521 escape values passed to --unset by @aiqiaoy in actions/checkout#2530 Various dependency updates Full Changelog: actions/[email protected] v7.0.0 What's Changed block checking out fork pr for pull_request_target and workflow_run by @aiqiaoy in actions/checkout#2454 Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 in the minor-actions-dependencies group across 1 directory by @dependabot[bot] in actions/checkout#2458 Bump flatted from 3.3.1 to 3.4.2 by @dependabot[bot] in actions/checkout#2460 Bump js-yaml from 4.1.0 to 4.2.0 by @dependabot[bot] in actions/checkout#2461 Bump @actions/core and @actions/tool-cache and Remove uuid by @dependabot[bot] in actions/checkout#2459 upgrade module to esm and update dependencies by @aiqiaoy in actions/checkout#2463 Bump the minor-npm-dependencies group across 1 directory with 3 updates by @dependabot[bot] in actions/checkout#2462 getting ready for checkout v7 release by @aiqiaoy in actions/checkout#2464 update error wording by @aiqiaoy in actions/checkout#2467 New Contributors @aiqiaoy made their first contribution in actions/checkout#2454 Full Changelog: actions/[email protected] v6.1.0 What's Changed [BREAKING] backport allow-unsafe-pr-checkout to v6 by @aiqiaoy in actions/checkout#2500 backport fixes to releases-v6 by @aiqiaoy in actions/checkout#2527 https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/ for more details about this breaking change Full Changelog: actions/[email protected] v6.0.3 What's Changed Update changelog by @ericsciple in actions/checkout#2357 fix: expand merge commit SHA regex and add SHA-256 test cases by @yaananth in actions/checkout#2414 Fix checkout init for SHA-256 repositories by @yaananth in actions/checkout#2439 Update changelog for v6.0.3 by @yaananth in actions/checkout#2446 New Contributors @yaananth made their first contribution in actions/checkout#2414 Full Changelog: actions/[email protected] v6.0.2 What's Changed Add orchestration_id to git user-agent when ACTIONS_ORCHESTRATION_ID is set by @TingluoHuang in actions/checkout#2355 ... (truncated) Changelog Sourced from actions/checkout's changelog. Changelog v7.0.1 Skip running unsafe pr check if input is default by @aiqiaoy in actions/checkout#2518 Trim only ascii whitespace for branch by @aiqiaoy in actions/checkout#2521 Escape values passed to --unset by @aiqiaoy in actions/checkout#2530 Various dependency updates v7.0.0 Block checking out fork PR for pull_request_target and workflow_run by @aiqiaoy in actions/checkout#2454 Various dependency updates v6.0.3 Fix checkout init for SHA-256 repositories by @yaananth in actions/checkout#2439 fix: expand merge commit SHA regex and add SHA-256 test cases by @yaananth in actions/checkout#2414 v6.0.2 Fix tag handling: preserve annotations and explicit fetch-tags by @ericsciple in actions/checkout#2356 v6.0.1 Add worktree support for persist-credentials includeIf by @ericsciple in actions/checkout#2327 v6.0.0 Persist creds to a separate file by @ericsciple in actions/checkout#2286 Update README to include Node.js 24 support details and requirements by @salmanmkc in actions/checkout#2248 v5.0.1 Port v6 cleanup to v5 by @ericsciple in actions/checkout#2301 v5.0.0 Update actions checkout to use node 24 by @salmanmkc in actions/checkout#2226 v4.3.1 Port v6 cleanup to v4 by @ericsciple in actions/checkout#2305 v4.3.0 docs: update README.md by @motss in actions/checkout#1971 Add internal repos for checking out multiple repositories by @mouismail in actions/checkout#1977 Documentation update - add recommended permissions to Readme by @benwells in actions/checkout#2043 Adjust positioning of user email note and permissions heading by @joshmgross in actions/checkout#2044 Update README.md by @nebuk89 in actions/checkout#2194 Update CODEOWNERS for actions by @TingluoHuang in actions/checkout#2224 Update package dependencies by @salmanmkc in actions/checkout#2236 v4.2.2 url-helper.ts now leverages well-known environment variables by @jww3 in actions/checkout#1941 Expand unit test coverage for isGhes by @jww3 in actions/checkout#1946 v4.2.1 Check out other refs/* by commit if provided, fall back to ref by @orhantoy in actions/checkout#1924 ... (truncated) Commits 3d3c42e prep v7.0.1 release (#2531) 2880268 escape values passed to --unset (#2530) 12cd223 trim only ascii whitespace for branch (#2521) 62661c4 skip running unsafe pr check if input is default (#2518) e8d4307 Bump the minor-actions-dependencies group with 2 updates (#2499) 631c942 eslint 9 (#2474) 4f1f4ae Bump actions/upload-artifact from 4 to 7 (#2476) ba09753 Bump actions/checkout from 6 to 7 (#2488) b9e0990 Bump docker/login-action from 3.3.0 to 4.2.0 (#2479) e8cb398 Bump docker/build-push-action from 6.5.0 to 7.2.0 (#2478) Additional commits viewable in compare view Updates actions/setup-python from 5.6.0 to 7.0.0 Release notes Sourced from actions/setup-python's releases. v7.0.0 What's Changed Enhancements Migrate to ESM and upgrade dependencies by @priyagupta108 in actions/setup-python#1330 Pin SHA commits and update docs with latest versions by @HarithaVattikuti in actions/setup-python#1338 Remove the pip-install input by @gowridurgad in actions/setup-python#1336 Bug Fix Fix to Classify stderr warning messages as warnings instead of errors in annotations by @lmvysakh in actions/setup-python#1335 Validate and retry manifest fetch to prevent silent failures by @priyagupta108 in actions/setup-python#1332 Dependency Upgrade Bump certifi from 2020.6.20 to 2024.7.4 in /tests/data by @dependabot in actions/setup-python#1328 Remove EOL Python versions and Bumps numpy text fixture by @priya-kinthali in actions/setup-python#1333 Upgrade @actions/cache to 6.2.0 by @philip-gai in actions/setup-python#1337 New Contributors @lmvysakh made their first contribution in actions/setup-python#1335 @philip-gai made their first contribution in actions/setup-python#1337 Full Changelog: actions/[email protected] v6.3.0 What's Changed Enhancement Add RHEL support and include Linux distro in cache keys by @priyagupta108 in actions/setup-python#1323 Fix pip cache error handling on Windows by @priyagupta108 in actions/setup-python#1040 Dependency update Upgrade minimatch from 3.1.2 to 3.1.5 by @dependabot in actions/setup-python#1281 Upgrade actions dependencies by @gowridurgad with @Copilot in actions/setup-python#1303 Upgrade @actions/cache to 5.1.0, log cache write denied by @jasongin in actions/setup-python#1324 Upgrade dependency versions and test workflow configuration by @HarithaVattikuti in actions/setup-python#1322 Documentation Update advanced-usage.md by @Dunky-Z in actions/setup-python#811 New Contributors @gowridurgad with @Copilot made their first contribution in actions/setup-python#1303 @jasongin made their first contribution in actions/setup-python#1324 @Dunky-Z made their first contribution in actions/setup-python#811 Full Changelog: actions/[email protected] v6.2.0 What's Changed Dependency Upgrades Upgrade dependencies to Node 24 compatible versions by @salmanmkc in actions/setup-python#1259 ... (truncated) Commits 5fda3b9 Pin SHA commits and update docs with latest versions (#1338) 4ab7e95 Merge pull request #1337 from actions/philip-gai/bump-actions-cache-6-2-0 0f3a009 Remove the pip-install input (#1336) f8cf429 Migrate to ESM and upgrade dependencies (#1330) 54baeea Validate and retry manifest fetch to prevent silent failures (#1332) c709277 Annotation code fix (#1335) 6849080 remove EOL Python versions and Bumps numpy text fixture (#1333) 0903b46 Bump certifi from 2020.6.20 to 2024.7.4 in /tests/data (#1328) ece7cb0 Fix pip cache error handling on Windows. (#1040) 1d18d7a Update advanced-usage.md (#811) Additional commits viewable in compare view Updates actions/upload-artifact from 4.6.2 to 7.0.1 Release notes Sourced from actions/upload-artifact's releases. v7.0.1 What's Changed Update the readme with direct upload details by @danwkennedy in actions/upload-artifact#795 Readme: bump all the example versions to v7 by @danwkennedy in actions/upload-artifact#796 Include changes in typespec/ts-http-runtime 0.3.5 by @yacaovsnc in actions/upload-artifact#797 Full Changelog: actions/[email protected] v7.0.0 v7 What's new Direct Uploads Adds support for uploading single files directly (unzipped). Callers can set the new archive parameter to false to skip zipping the file during upload. Right now, we only support single files. The action will fail if the glob passed resolves to multiple files. The name parameter is also ignored with this setting. Instead, the name of the artifact will be the name of the uploaded file. ESM To support new versions of the @actions/* packages, we've upgraded the package to ESM. What's Changed Add proxy integration test by @Link- in actions/upload-artifact#754 Upgrade the module to ESM and bump dependencies by @danwkennedy in actions/upload-artifact#762 Support direct file uploads by @danwkennedy in actions/upload-artifact#764 New Contributors @Link- made their first contribution in actions/upload-artifact#754 Full Changelog: actions/[email protected] v6.0.0 v6 - What's new [!IMPORTANT] actions/upload-artifact@v6 now runs on Node.js 24 (runs.using: node24) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading. Node.js 24 This release updates the runtime to Node.js 24. v5 had preliminary support for Node.js 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24. What's Changed Upload Artifact Node 24 support by @salmanmkc in actions/upload-artifact#719 fix: update @actions/artifact for Node.js 24 punycode deprecation by @salmanmkc in actions/upload-artifact#744 prepare release v6.0.0 for Node.js 24 support by @salmanmkc in actions/upload-artifact#745 Full Changelog: actions/[email protected] v5.0.0 What's Changed ... (truncated) Commits 043fb46 Merge pull request #797 from actions/yacaovsnc/update-dependency 634250c Include changes in typespec/ts-http-runtime 0.3.5 e454baa Readme: bump all the example versions to v7 (#796) 74fad66 Update the readme with direct upload details (#795) bbbca2d Support direct file uploads (#764) 589182c Upgrade the module to ESM and bump dependencies (#762) 47309c9 Merge pull request #754 from actions/Link-/add-proxy-integration-tests 02a8460 Add proxy integration test b7c566a Merge pull request #745 from actions/upload-artifact-v6-release e516bc8 docs: correct description of Node.js 24 support in README Additional commits viewable in compare view Updates ansible-community/ansible-test-gh-action from 1.17.0 to 1.18.0 Release notes Sourced from ansible-community/ansible-test-gh-action's releases. v1.18.0 What's Changed Project Changes Support ansible-core 2.20 and 2.21, bump default ansible-core version to 2.21 by @felixfontein in ansible-community/ansible-test-gh-action#125 Dependencies Bump codecov/codecov-action from 4.5.0 to 5.4.3 by @dependabot[bot] in ansible-community/ansible-test-gh-action#101 Bump actions/checkout from 4 to 5 by @dependabot[bot] in ansible-community/ansible-test-gh-action#104 Bump codecov/codecov-action from 5.4.3 to 5.5.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#105 Bump codecov/codecov-action from 5.5.0 to 5.5.1 by @dependabot[bot] in ansible-community/ansible-test-gh-action#107 Bump actions/setup-python from 5 to 6 by @dependabot[bot] in ansible-community/ansible-test-gh-action#108 Bump actions/checkout from 5 to 6 by @dependabot[bot] in ansible-community/ansible-test-gh-action#110 Bump codecov/codecov-action from 5.5.1 to 5.5.2 by @dependabot[bot] in ansible-community/ansible-test-gh-action#111 Bump codecov/codecov-action from 5.5.2 to 5.5.3 by @dependabot[bot] in ansible-community/ansible-test-gh-action#114 Bump codecov/codecov-action from 5.5.3 to 6.0.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#115 Bump codecov/codecov-action from 6.0.0 to 6.0.1 by @dependabot[bot] in ansible-community/ansible-test-gh-action#119 Bump codecov/codecov-action from 6.0.1 to 7.0.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#122 Bump actions/checkout from 6 to 7 by @dependabot[bot] in ansible-community/ansible-test-gh-action#126 Full Changelog: ansible-community/[email protected] Commits 6ded727 Merge pull request #126 from ansible-community/dependabot/github_actions/acti... e0d4c98 Bump actions/checkout from 6 to 7 6c86f3f Merge pull request #125 from felixfontein/ansible-core 48b041f Merge pull request #122 from ansible-community/dependabot/github_actions/code... 3272591 Merge pull request #124 from felixfontein/fix-pre-commit c0626df Bump default ansible-core to 2.21 7dfd27a Support ansible-core 2.20 and 2.21 c8e46ea Bump pre-commit flake8 additional deps 13e4993 Bump codecov/codecov-action from 6.0.1 to 7.0.0 8b1ac34 Merge pull request #119 from ansible-community/dependabot/github_actions/code... Additional commits viewable in compare view Updates actions/github-script from 7.1.0 to 9.0.0 Release notes Sourced from actions/github-script's releases. v9.0.0 New features: getOctokit factory function — Available directly in the script context. Create additional authenticated Octokit clients with different tokens for multi-token workflows, GitHub App tokens, and cross-org access. See Creating additional clients with getOctokit for details and examples. Orchestration ID in user-agent — The ACTIONS_ORCHESTRATION_ID environment variable is automatically appended to the user-agent string for request tracing. Breaking changes: require('@actions/github') no longer works in scripts. The upgrade to @actions/github v9 (ESM-only) means require('@actions/github') will fail at runtime. If you previously used patterns like const { getOctokit } = require('@actions/github') to create secondary clients, use the new injected getOctokit function instead — it's available directly in the script context with no imports needed. getOctokit is now an injected function parameter. Scripts that declare const getOctokit = ... or let getOctokit = ... will get a SyntaxError because JavaScript does not allow const/let redeclaration of function parameters. Use the injected getOctokit directly, or use var getOctokit = ... if you need to redeclare it. If your script accesses other @actions/github internals beyond the standard github/octokit client, you may need to update those references for v9 compatibility. What's Changed Add ACTIONS_ORCHESTRATION_ID to user-agent string by @Copilot in actions/github-script#695 ci: use deployment: false for integration test environments by @salmanmkc in actions/github-script#712 feat!: add getOctokit to script context, upgrade @actions/github v9, @octokit/core v7, and related packages by @salmanmkc in actions/github-script#700 New Contributors @Copilot made their first contribution in actions/github-script#695 Full Changelog: actions/[email protected] v8.0.0 What's Changed Update Node.js version support to 24.x by @salmanmkc in actions/github-script#637 README for updating actions/github-script from v7 to v8 by @sneha-krip in actions/github-script#653 ⚠️ Minimum Compatible Runner Version v2.327.1 Release Notes Make sure your runner is updated to this version or newer to use this release. New Contributors @salmanmkc made their first contribution in actions/github-script#637 @sneha-krip made their first contribution in actions/github-script#653 Full Changelog: actions/[email protected] Commits 3a2844b Merge pull request #700 from actions/salmanmkc/expose-getoctokit + prepare re... ca10bbd fix: use @octokit/core/types import for v7 compatibility 86e48e2 merge: incorporate main branch changes c108472 chore: rebuild dist for v9 upgrade and getOctokit factory afff112 Merge pull request #712 from actions/salmanmkc/deployment-false + fix user-ag... ff8117e ci: fix user-agent test to handle orchestration ID 81c6b78 ci: use deployment: false to suppress deployment noise from integration tests 3953caf docs: update README examples from @v8 to @v9, add getOctokit docs and v9 brea... c17d55b ci: add getOctokit integration test job a047196 test: add getOctokit integration tests via callAsyncFunction Additional commits viewable in compare view Updates dawidd6/action-download-artifact from 16 to 21 Release notes Sourced from dawidd6/action-download-artifact's releases. v21 What's Changed build(deps): bump @actions/github from 9.0.0 to 9.1.0 by @dependabot[bot] in dawidd6/action-download-artifact#396 build(deps): bump filesize from 11.0.15 to 11.0.16 by @dependabot[bot] in dawidd6/action-download-artifact#399 build(deps): bump fast-xml-parser from 5.5.7 to 5.7.1 by @dependabot[bot] in dawidd6/action-download-artifact#402 build(deps): bump @actions/github from 9.1.0 to 9.1.1 by @dependabot[bot] in dawidd6/action-download-artifact#400 build(deps): bump @actions/core from 3.0.0 to 3.0.1 by @dependabot[bot] in dawidd6/action-download-artifact#401 build(deps): bump filesize from 11.0.16 to 11.0.17 by @dependabot[bot] in dawidd6/action-download-artifact#404 Download artifacts in creation order by @matejdro in dawidd6/action-download-artifact#398 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#405 New Contributors @matejdro made their first contribution in dawidd6/action-download-artifact#398 Full Changelog: dawidd6/[email protected] v20 What's Changed build(deps): bump fast-xml-parser from 5.5.6 to 5.5.7 by @dependabot[bot] in dawidd6/action-download-artifact#387 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#388 build(deps): bump filesize from 11.0.13 to 11.0.14 by @dependabot[bot] in dawidd6/action-download-artifact#389 build(deps): bump brace-expansion by @dependabot[bot] in dawidd6/action-download-artifact#390 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#391 build(deps): bump filesize from 11.0.14 to 11.0.15 by @dependabot[bot] in dawidd6/action-download-artifact#392 build(deps): bump adm-zip from 0.5.16 to 0.5.17 by @dependabot[bot] in dawidd6/action-download-artifact#393 build(deps): bump lodash from 4.17.23 to 4.18.1 by @dependabot[bot] in dawidd6/action-download-artifact#394 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#395 Full Changelog: dawidd6/[email protected] v19 What's Changed build(deps): bump fast-xml-parser from 5.4.1 to 5.5.6 by @dependabot[bot] in dawidd6/action-download-artifact#385 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#386 Full Changelog: dawidd6/[email protected] v18 What's Changed build(deps): bump @actions/artifact from 6.2.0 to 6.2.1 by @dependabot[bot] in dawidd6/action-download-artifact#381 build(deps): bump undici from 6.23.0 to 6.24.0 by @dependabot[bot] in dawidd6/action-download-artifact#382 node_modules: update by @dawidd6 in dawidd6/action-download-artifact#383 Full Changelog: dawidd6/[email protected] v17 What's Changed ... (truncated) Commits b6e2e70 node_modules: update (#405) 1708cb3 Download artifacts in creation order (#398) 00b585a build(deps): bump filesize from 11.0.16 to 11.0.17 (#404) 0414c42 build(deps): bump @actions/core from 3.0.0 to 3.0.1 (#401) c802aad build(deps): bump @actions/github from 9.1.0 to 9.1.1 (#400) ef06691 build(deps): bump fast-xml-parser from 5.5.7 to 5.7.1 (#402) 026702e build(deps): bump filesize from 11.0.15 to 11.0.16 (#399) 09d0677 build(deps): bump @actions/github from 9.0.0 to 9.1.0 (#396) 8305c0f node_modules: update (#395) 542af03 build(deps): bump lodash from 4.17.23 to 4.18.1 (#394) Additional commits viewable in compare view Updates SonarSource/sonarqube-scan-action from 7.0.0 to 8.2.1 Release notes Sourced from SonarSource/sonarqube-scan-action's releases. v8.2.1 What's Changed Bug fix SQSCANGHA-156 GPG signature verification fails when temporary directory path is too long Full Changelog: SonarSource/[email protected] v8.2.0 What's Changed SQSCANGHA-149 Add scannerBinariesAuthHeader input by @henryju in SonarSource/sonarqube-scan-action#246 SQSCANGHA-88 Deprecate the SONARCLOUD_URL env variable support by @henryju in SonarSource/sonarqube-scan-action#249 SQSCANGHA-84 Remove outdated wget/curl references by @henryju in SonarSource/sonarqube-scan-action#248 SQSCANGHA-135 Fix scanner binaries always re-downloaded due to incompatible 4-part version by @henryju in SonarSource/sonarqube-scan-action#250 SQSCANGHA-127 Rename downloaded file to .zip before extraction on Windows by @henryju in SonarSource/sonarqube-scan-action#251 Full Changelog: SonarSource/[email protected] v8.1.0 What's Changed SQSCANGHA-146 Add proxy support for GPG keyserver access by @henryju in SonarSource/sonarqube-scan-action#244 SQSCANGHA-148 Update SonarScanner CLI to 8.1.0.6389 by @github-actions[bot] in SonarSource/sonarqube-scan-action#232 Full Changelog: SonarSource/[email protected] v8.0.0 What's Changed Breaking change SQSCANGHA-145 Set skipSignatureVerification default value to false by @antoine-vinot-sonarsource in SonarSource/sonarqube-scan-action#241 Full Changelog: SonarSource/[email protected] v7.2.1 What's Changed SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change by @gmmcal in SonarSource/sonarqube-scan-action#240 Full Changelog: SonarSource/[email protected] v7.2.0 What's Changed SQSCANGHA-133 Upgrade the Node version used in UTs + contribution guide by @claire-villard-sonarsource in SonarSource/sonarqube-scan-action#226 SC-45750 Migrate to dateless license headers by @claire-villard-sonarsource in SonarSource/sonarqube-scan-action#229 SQSCANGHA-134 Upgrade the libraries to latest version by @claire-villard-sonarsource in SonarSource/sonarqube-scan-action#227 ... (truncated) Commits 2291811 SQSCANGHA-156 GPG signature verification fails when temporary directory path ... 7cdc154 SQSCANGHA-153 NO-JIRA Bump actions/checkout from 6.0.2 to 7.0.0 (#255) 45f2736 SQSCANGHA-151 Change Code Owners (#254) 7138816 SQSCANGHA-127 Rename downloaded file to .zip before extraction on Windows (#251) 3581139 SQSCANGHA-135 Fix scanner binaries always re-downloaded due to incompatible 4... c9d327c SQSCANGHA-84 Remove outdated wget/curl references b243e51 SQSCANGHA-88 Deprecate the SONARCLOUD_URL env variable support 375c3f5 SQSCANGHA-149 Add scannerBinariesAuthHeader input for authenticated binary do... 9c78323 SQSCANGHA-144 Add gate jobs to QA workflows for branch protection 7006c44 Update SonarScanner CLI to 8.1.0.6389 Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) @dependabot unignore <dependency name> will remove all of the ignore con... Description has been truncated Reviewed-by: Mark Chappell

tremble requested a review from alinabuzachis January 21, 2025 11:50

tremble force-pushed the error_handlers/s3_bucket branch from 6c42750 to 340c1e8 Compare January 21, 2025 12:01

tremble requested a review from hakbailey January 22, 2025 07:38

tremble force-pushed the error_handlers/s3_bucket branch from 340c1e8 to f27d872 Compare January 28, 2025 12:28

alinabuzachis approved these changes Jan 28, 2025

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 28, 2025

github-actions Bot added the backport-9 label Jan 28, 2025

tremble added do_not_backport This PR should not be backported to stable- branches unless absolutely necessary and removed backport-9 labels Jan 28, 2025

tremble added 4 commits January 28, 2025 14:43

Rework S3 bucket

53febd3

changelog

597f360

unit test

4a7cd39

Python 3.8 compilation fix

f64243e

tremble force-pushed the error_handlers/s3_bucket branch from c14f901 to f64243e Compare January 28, 2025 13:46

softwarefactory-project-zuul Bot merged commit 0030805 into ansible-collections:main Jan 28, 2025

tremble mentioned this pull request Feb 3, 2025

Minor typing fixups #2497

Merged

tremble linked an issue Feb 4, 2025 that may be closed by this pull request

Bucket Policy upload fails due to GetBucketRequestPayment not being implemented (Ceph) #2447

Closed

1 task

This was referenced Feb 4, 2025

Bucket Policy upload fails due to GetBucketRequestPayment not being implemented (Ceph) #2447

Closed

[WIP] Rework s3_object to use ErrorHandler model #2510

Closed

ramondeklein mentioned this pull request Nov 19, 2025

Also treat NotSupported error as a 501 in v9 #2765

Closed

tremble deleted the error_handlers/s3_bucket branch April 19, 2026 14:58

Uh oh!

Conversation

tremble commented Jan 21, 2025

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

github-actions Bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docs Build 📝

Uh oh!

softwarefactory-project-zuul Bot commented Jan 21, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jan 28, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jan 28, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jan 28, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jan 28, 2025

Uh oh!

vdl-dsi-architecture commented Nov 19, 2025

Uh oh!

tremble commented Nov 19, 2025

Uh oh!

vdl-dsi-architecture commented Nov 19, 2025

Uh oh!

tremble commented Nov 19, 2025

Uh oh!

vdl-dsi-architecture commented Nov 19, 2025

Uh oh!

tremble commented Nov 19, 2025

Uh oh!

marktheunissen commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramondeklein commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jan 21, 2025 •

edited

Loading

marktheunissen commented Nov 19, 2025 •

edited

Loading

ramondeklein commented Nov 19, 2025 •

edited

Loading