Conversation
github-actions
bot
added
dependencies
|
Please add a PR summary noting which changes were manual and which were automagic |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request replaces Black with Ruff for code formatting and linting. Key changes include reformatting multi-line expressions (e.g., dictionary comprehensions and import statements), removing Black configuration and hooks, and updating Ruff and pre-commit configurations to enforce the new formatting rules.
Reviewed Changes
Copilot reviewed 51 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/molecule/command/list.py | Reformatted dictionary comprehension to multiple lines |
| src/molecule/command/init/*.py | Added extra blank lines and reformatted imports |
| src/molecule/command/idempotence.py | Minor formatting update with added blank line |
| src/molecule/command/drivers.py | Minor formatting update with added blank line |
| src/molecule/command/destroy.py | Minor formatting update with added blank line |
| src/molecule/command/dependency.py | Minor formatting update with added blank line |
| src/molecule/command/create.py | Minor formatting update with added blank line |
| src/molecule/command/converge.py | Minor formatting update with added blank line |
| src/molecule/command/cleanup.py | Minor formatting update with added blank line |
| src/molecule/command/check.py | Reformatted dictionary definition for clarity |
| src/molecule/main.py | Added a blank line above imports |
| src/molecule/init.py | Added a blank line above imports |
| pyproject.toml | Removed Black config and updated Ruff settings; changed known-first-party entry |
| .pre-commit-config.yaml | Removed Black hook and updated Ruff hook command |
Files not reviewed (4)
- .config/constraints.txt: Language not supported
- .config/requirements-test.txt: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
Comments suppressed due to low confidence (1)
pyproject.toml:379
- The known-first-party value has been changed from "molecule" to "src". Please confirm that this change correctly reflects the project structure and intended package naming.
known-first-party = ["src"]
cidrblock
approved these changes
Apr 3, 2025
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use ruff format on most of devtools projects.
Related: AAP-43336