Add docker network#1097
Merged
retr0h merged 5 commits intoansible:masterfrom Jan 24, 2018
dj-wasabi:add_docker_network
Merged
Conversation
|
Amazing work. Thank you. |
Contributor
|
Hi @dj-wasabi Can you update the cookiecutter molecule.yml with the whole default omit pattern. Also, can you update the test files and docker driver (for documentation) as well. See #1092 for reference. |
Author
|
Thank you for the suggestion. I believe I have updated all files which were also in the PR you mentioned, if not please let me know and will update them to with this PR. |
Contributor
|
Hi @dj-wasabi can you be sure to update the docker driver class comments so the documentation gets updated. I believe #1092 does this for reference. |
Author
|
Hi @retr0h Sorry! I thought I had updated that file to/ |
Contributor
|
@dj-wasabi Thanks as usual ! 🎸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following change:
create.ymlanddelete.ymlplaybooks;A filter
molecule_get_docker_networkswill be used that checks if anetworkskey is configured in the platforms. If so, it then checks if it has anamekey and if that exists to, this name will be used with creating or deleting the docker network. If nonetworkskey is configured in the platform (Or if so, but has nonamekey), then an empty list is returned and task is skipped.Example usage for
molecule.yml:If a better approach is needed, please let me know and I'll try again.
(I hope I have updated all correct test files :-) )