chore: Remove json schema as a direct dependency, let builder handle it#390
Merged
cidrblock merged 2 commits intoansible:mainfrom Dec 1, 2025
Merged
Conversation
cidrblock
requested review from
alisonlhart,
Copilot and
ssbarnea
and removed request for
a team
cidrblock
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes jsonschema as a direct dependency from the project, allowing ansible-builder (which already depends on jsonschema) to manage the compatible version range. This eliminates redundant dependency declaration since the codebase does not directly import or use jsonschema.
Key Changes
- Removed
jsonschema>=4.25.1from direct dependencies inpyproject.toml - Updated
uv.lockto reflect the removal (jsonschema remains available as a transitive dependency through ansible-builder)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed jsonschema from direct dependencies list |
| uv.lock | Updated lock file to reflect dependency changes, removing jsonschema from direct dependencies while keeping it as a transitive dependency through ansible-builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
alisonlhart
approved these changes
Dec 1, 2025
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADE has no direct dep of json schema, will let builder own the compatible range.