feat: change default isolation mode from 'restrictive' to 'cfg' (#345)

cidrblock · web-flow · commit e578ab2c2314 · 2025-07-28T11:03:53.000Z
- Update default isolation mode to 'cfg' in arg_parser.py
- Update test cases to explicitly use 'restrictive' mode where needed
- This makes the cfg isolation mode the default behavior for better workspace isolation
diff --git a/src/ansible_dev_environment/arg_parser.py b/src/ansible_dev_environment/arg_parser.py
@@ -260,7 +260,7 @@ def parse() -> argparse.Namespace:
             " cfg: Update or add an ansible.cfg file in the current working directory to isolate the workspace"
             " none: No isolation, not recommended."
         ),
-        default="restrictive",
+        default="cfg",
         choices=["restrictive", "cfg", "none"],
         type=str,
     )
diff --git a/tests/unit/test_cli.py b/tests/unit/test_cli.py
@@ -140,7 +140,7 @@ def test_acp_env_var_set(
         monkeypatch: Pytest fixture.
     """
     monkeypatch.setenv(env_var, "test")
-    monkeypatch.setattr("sys.argv", ["ansible-dev-environment", "install"])
+    monkeypatch.setattr("sys.argv", ["ansible-dev-environment", "install", "--im", "restrictive"])
     with pytest.raises(SystemExit):
         main(dry=True)
     captured = capsys.readouterr()
@@ -162,7 +162,7 @@ def test_collections_in_home(
     """
     monkeypatch.setattr(
         "sys.argv",
-        ["ansible-dev-environment", "install", "--venv", "venv"],
+        ["ansible-dev-environment", "install", "--venv", "venv", "--im", "restrictive"],
     )
     monkeypatch.setenv("HOME", str(tmp_path))
     monkeypatch.setenv("ANSIBLE_HOME", str(tmp_path / ".ansible"))
@@ -222,7 +222,7 @@ def _iterdir(path: Path) -> list[Path] | Generator[Path, None, None]:
 
     monkeypatch.setattr(
         "sys.argv",
-        ["ansible-dev-environment", "install", "--venv", "venv"],
+        ["ansible-dev-environment", "install", "--venv", "venv", "--im", "restrictive"],
     )
     with pytest.raises(SystemExit):
         main(dry=True)

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ def parse() -> argparse.Namespace:`
`260`	`260`	`" cfg: Update or add an ansible.cfg file in the current working directory to isolate the workspace"`
`261`	`261`	`" none: No isolation, not recommended."`
`262`	`262`	`),`
`263`		`- default="restrictive",`
	`263`	`+ default="cfg",`
`264`	`264`	`choices=["restrictive", "cfg", "none"],`
`265`	`265`	`type=str,`
`266`	`266`	`)`