fix: enforce GITHUB_TOKEN for ghcr.io registry login#570
Merged
NilashishC merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
The `||` fallback in the container registry login step allowed REGISTRY_USERNAME/REGISTRY_PASSWORD secrets to override the default GITHUB_TOKEN credentials even when the target registry was ghcr.io. Replace the fallback with an explicit branch: ghcr.io always authenticates with github.actor + secrets.GITHUB_TOKEN; any other registry uses secrets.REGISTRY_USERNAME + secrets.REGISTRY_PASSWORD. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Made-with: Cursor
shatakshiiii
approved these changes
Mar 31, 2026
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
||fallback in the container registry login step allowedREGISTRY_USERNAME/REGISTRY_PASSWORDsecrets to override the defaultGITHUB_TOKENcredentials even when the target registry wasghcr.io. Replace the fallback with an explicit branch:ghcr.ioalways authenticates withgithub.actor+secrets.GITHUB_TOKEN; any other registry usessecrets.REGISTRY_USERNAME+secrets.REGISTRY_PASSWORD.The current behavior is problematic if REGISTRY_* secrets are configured at an Org-level and the build in a repo has been invoked with
ghcr.ioas the target registry. Instead of using GITHUB_TOKEN, or github.actor, it will use REGISTRY_* to perform the login.