feat: wire ee_file_name through CLI so scaffolded EE projects use the custom filename#557
Merged
feat: wire ee_file_name through CLI so scaffolded EE projects use the custom filename#557
ee_file_name through CLI so scaffolded EE projects use the custom filename#557Conversation
NilashishC
changed the title
ee_file_name through CLI so scaffolded EE projects use the custom filename
4 tasks
NilashishC
force-pushed
the
feat/add_ee_file_name_arg
branch
from
fa2bed9 to
02862d9
Compare
…custom filename. The ee_file_name field was added to EEConfig in #548 but was never exposed as a CLI argument,so users couldn't actually set it. The generated EE definition file was always named execution-environment.yml regardless of configuration. Add --ee-file-name CLI argument to init execution_env with validation via EEConfig._validate_ee_file_name (rejects paths, requires .yml/.yaml extension) Add ee_file_name field to Config dataclass so the parsed arg flows through to the init subcommand. Override ee_file_name in _build_ee_config when a non-default value is provided via CLI Register execution-environment.yml in PATH_REPLACERS so the Walker renames the scaffolded file to match ee_file_name. Signed-off-by: NilashishC <[email protected]>
Signed-off-by: NilashishC <[email protected]>
Signed-off-by: NilashishC <[email protected]>
NilashishC
force-pushed
the
feat/add_ee_file_name_arg
branch
from
02862d9 to
6d6b535
Compare
cidrblock
approved these changes
Mar 24, 2026
Collaborator
cidrblock
left a comment
cidrblock
left a comment
There was a problem hiding this comment.
LGTM — follows the existing CLI-override pattern used by --ee-name and --ee-base-image. The PATH_REPLACERS integration for file renaming is clean.
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ee_file_namefield was added to EEConfig in #548 but was never exposed as a CLI argument, so users couldn't actually set it. The generated EE definition file was always namedexecution-environment.ymlregardless of configuration.Add
--ee-file-nameCLI argument to init execution_env with validation via EEConfig._validate_ee_file_name (rejects paths, requires .yml/.yaml extension) Add ee_file_name field to Config dataclass so the parsed arg flows through to the init subcommand.Override
ee_file_namein_build_ee_configwhen a non-default value is provided via CLI Register execution-environment.yml inPATH_REPLACERSso theWalkerrenames the scaffolded file to matchee_file_name.