fix(devfile): align with OCP 4.20+ / Dev Spaces 3.25+ container-in-container#540
Merged
cidrblock merged 2 commits intoansible:mainfrom Mar 18, 2026
Merged
fix(devfile): align with OCP 4.20+ / Dev Spaces 3.25+ container-in-container#540cidrblock merged 2 commits intoansible:mainfrom
cidrblock merged 2 commits intoansible:mainfrom
Conversation
…ntainer - Remove KUBEDOCK_ENABLED env; no longer needed with native container-in-container (Dev Spaces operator injects context). - Remove container args; ansible-devspaces image uses ENTRYPOINT/CMD. Aligns scaffolded devfile with ansible/ansible-dev-tools#709. Made-with: Cursor
…ile) Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy container overrides from the devfile scaffolding template and updates fixture devfiles accordingly, aligning generated devfiles with the default behavior of the ansible-devspaces image.
Changes:
- Removed the container
args: ["tail", "-f", "/dev/null"]override from devfile template and fixtures. - Removed the
KUBEDOCK_ENABLEDenvironment variable from devfile template and fixtures. - Removed
KUBEDOCKfrom the repository dictionary list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/fixtures/project/playbook_project/devfile.yaml | Updates expected scaffolded devfile fixture to match new template output. |
| tests/fixtures/collection/testorg/testcol/devfile.yaml | Updates expected scaffolded devfile fixture to match new template output. |
| src/ansible_creator/resources/common/devfile/devfile.yaml.j2 | Removes KUBEDOCK env var and tail -f /dev/null args from generated devfile. |
| .config/dictionary.txt | Removes now-unused KUBEDOCK dictionary entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
shatakshiiii
approved these changes
Mar 18, 2026
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the scaffolded devfile so it matches the current ansible-devspaces image and OCP 4.20+ / Dev Spaces 3.25+ behavior (native container-in-container; no kubedock).
Changes
KUBEDOCK_ENABLED— Not needed when using native container-in-container; the Dev Spaces operator injects the correct context on 3.25+/4.20+.args— Theghcr.io/ansible/ansible-devspacesimage definesENTRYPOINTandCMD; overrides are unnecessary.Alignment
ansible-creator initoransible-creator add resource devfileget a devfile that works with the same image and cluster target.Test
ansible-creator init(playbook or collection) and confirmdevfile.yamlhas noKUBEDOCK_ENABLEDorargs.Made with Cursor