Skip to content

feat: add agents.md with compiled best practices (MVP)#485

Merged
ssbarnea merged 3 commits intomainfrom
fix/agents2
Oct 13, 2025
Merged

feat: add agents.md with compiled best practices (MVP)#485
ssbarnea merged 3 commits intomainfrom
fix/agents2

Conversation

@ssbarnea
Copy link
Copy Markdown
Member

@ssbarnea ssbarnea commented Oct 8, 2025

This is an initial MVP agents.md file and the main goal while reviewing it is to spot anything that we do not want to recommend. Missing practices is ok as we can always improve it.

Fixes: AAP-55525

@ssbarnea ssbarnea requested a review from a team as a code owner October 8, 2025 15:18
@ssbarnea ssbarnea enabled auto-merge (squash) October 8, 2025 15:18
@github-actions github-actions bot added the feat label Oct 8, 2025
@github-actions github-actions bot added feat and removed feat labels Oct 9, 2025
@ssbarnea ssbarnea changed the title feat: add agents.md file into the docs feat: add agents.md with compiled best practices Oct 9, 2025
cidrblock

This comment was marked as resolved.

@ssbarnea

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive Ansible coding guidelines document for AI agents. The primary purpose is to create a centralized resource containing best practices for AI agents working with Ansible code, ensuring consistency and quality.

  • Creates a detailed guidelines document with best practices for Ansible development workflows, coding standards, and project structures
  • Adds supporting instructions for AI agents to generate and maintain the guidelines document
  • Updates configuration files to support the new documentation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/AGENTS.md Instructions for AI agents to analyze and update the main guidelines document
docs/agents.md Comprehensive Ansible coding guidelines covering workflows, standards, and best practices
cspell.config.yaml Adds technical terms to spell check ignore list
AGENTS.md Updates testing instructions to use tox instead of pre-commit
.config/dictionary.txt Adds FQCN-related terms to dictionary

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tools/AGENTS.md Outdated
Comment thread docs/agents.md Outdated
Comment thread docs/agents.md
Copy link
Copy Markdown
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving b/c a think it is a great start. Let's see if we can get some reviews from outside the team as well.

@github-project-automation github-project-automation bot moved this from In Progress to Review in 🧰 devtools project board Oct 10, 2025
@cidrblock cidrblock requested a review from tima October 10, 2025 15:13
@ssbarnea ssbarnea changed the title feat: add agents.md with compiled best practices feat: add agents.md with compiled best practices (MVP) Oct 10, 2025
@github-actions github-actions bot added feat and removed feat labels Oct 10, 2025
@github-actions github-actions bot added feat and removed feat labels Oct 10, 2025
@alisonlhart
Copy link
Copy Markdown
Contributor

alisonlhart commented Oct 11, 2025

I think this document is a great start, and we can continue to iterate.

Comment thread docs/agents.md
ssbarnea added a commit that referenced this pull request Oct 13, 2025
ssbarnea added a commit that referenced this pull request Oct 13, 2025
@github-actions github-actions bot added feat and removed feat labels Oct 13, 2025
@ssbarnea ssbarnea requested a review from alisonlhart October 13, 2025 12:26
@ssbarnea ssbarnea merged commit b45ee90 into main Oct 13, 2025
20 checks passed
@ssbarnea ssbarnea deleted the fix/agents2 branch October 13, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants