Validate some markup in documentation in validate-modules - #76262
Merged
Conversation
ansibot
added
WIP
affects_2.13
needs_triage
Contributor
|
The test |
ansibot
removed
the
ci_verified
This was referenced Nov 9, 2021
felixfontein
changed the title
Contributor
Author
|
ready_for_review |
This was referenced Nov 9, 2021
Merged
Merged
ansible-zuul Bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Nov 9, 2021
Fix docs issues. SUMMARY Fix some docs issues exhibited by ansible/ansible#76262. ISSUE TYPE Docs Pull Request COMPONENT NAME some modules Reviewed-by: Brian Scholer <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
briantist
reviewed
Nov 9, 2021
ansible-zuul Bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Nov 10, 2021
Fix docs issues. SUMMARY Fix some docs issues exhibited by ansible/ansible#76262. ISSUE TYPE Docs Pull Request COMPONENT NAME some modules Reviewed-by: Brian Scholer <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
russoz
reviewed
Nov 10, 2021
…/validate_modules/schema.py Co-authored-by: Alexei Znamensky <[email protected]>
ansibot
added
needs_ci
Contributor
|
Looking better to me, but to be fair I am not familiar with that code - nor likely to become in the near future. |
s-hertel
self-requested a review
November 11, 2021 15:31
s-hertel
approved these changes
Nov 11, 2021
felixfontein
commented
Nov 11, 2021
s-hertel
reviewed
Nov 11, 2021
Contributor
|
@felixfontein Thanks for the PR! |
Contributor
Author
|
@briantist @russoz @s-hertel thanks a lot for reviewing and merging! :) |
jborean93
removed
the
needs_triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prevent
M(...)from not containing a FQCN, etc.ISSUE TYPE
COMPONENT NAME
validate-modules