Add `Image` component for sharing Docker images by MengLinMaker · Pull Request #6359 · anomalyco/sst

MengLinMaker · 2026-01-26T22:07:57Z

Adding Image component for #6304:

Create image.ts component:
- Initial creation
Refactor function.ts and fargate.ts to use image.ts
- function.ts
- fargate.ts
Test changes against sst examples:
- examples/aws-task
- examples/aws-python-container - only python uses container for Lambda function
Add docs

Although efforts has been made to preserve functionality. Some behaviors may change:

fargate.ts image name is changed. Can be preserved via transform.

MengLinMaker · 2026-01-26T22:16:50Z

@vimtor the test in platform fails since bun lacks features from node, which are required for pulumi. I will use npm node for now. Though I believe pnpm will offer a better monorepo experience.

# Unhandled error between tests
-------------------------------
26 | // high-quality error messages.
27 | //
28 | // As a side-effect of importing this file, we must enable the --allow-natives-syntax V8 flag. This
29 | // is because we are using V8 intrinsics in order to implement this module.
30 | const v8 = __importStar(require("v8"));
31 | v8.setFlagsFromString("--allow-natives-syntax");
        ^
NotImplementedError: node:v8 setFlagsFromString is not yet implemented in Bun.
 code: "ERR_NOT_IMPLEMENTED"

      at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/v8.js:31:4
      at anonymous (unknown:1:1)
      at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/createClosure.js:29:7
      at anonymous (unknown:1:1)
      at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/serializeClosure.js:61:78
      at anonymous (unknown:1:1)
      at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/index.js:29:1

vimtor · 2026-01-26T22:19:40Z

hey @MengLinMaker no need to upgrade vitest or write tests for this feature

i'm working on a better testing setup. for the moment you can test the components against one of the local examples as described in the README

MengLinMaker · 2026-01-26T22:31:25Z

AFAIK some sst examples are set to use latest version from npm. But we want to use the sst currently being changed...

Are you implying the local sst should be installed globally?

MengLinMaker · 2026-01-27T02:44:06Z

Ah thanks its in the root README #running-locally

Then sst diff against an empty AWS account for snapshots

vimtor · 2026-01-27T08:45:30Z

i usually do:

clone the repo
bun install
go mod tidy
cd platform && bun run build
cd examples/<example> && bun install
go run ../../cmd/sst dev (or deploy)

if you make changes you should run 4 and 6 again

This reverts commit fd174a0.

MengLinMaker · 2026-01-29T21:10:11Z

Not quite ready to merge, but I'd like confirm that current changes are desired.

Refactoring fargate.ts and function.ts doesn't add anything new, just cleaner abstractions.

Adding ability to use input image directly into service.ts should be straight forward.

MengLinMaker · 2026-02-01T22:49:29Z

Link issue #6304
Could also investigate #6369 after completion

vimtor · 2026-02-27T13:00:16Z

@MengLinMaker this looks very promising

…e uri

MengLinMaker · 2026-03-02T14:19:48Z

Progress update 2026-03-03

The main issue is that the image that lambda uses is not updating, as the api is not updating.

I'm experiencing flaky deployments after refactoring the function.ts component to use image.ts. Somehow image uri is not available despite explicitly instructing pulumi to wait until image output is available. But AWS console shows that the uri is correct and deployed.

The error:

sdk-v2/provider2.go:515:
sdk.helper_schema: updating Lambda Function (aws-python-container-menglinmaker-PythonFnFunction-fxxadnar)
code: operation error Lambda: UpdateFunctionCode,
https response error StatusCode: 400, RequestID: 3a5010bd-2f70-4ef9-bb85-7cc19f62a16c,
InvalidParameterValueException: Source image 585946893245.dkr.ecr.ap-southeast-2.amazonaws.com/sst-asset:PythonFn@sha256:84d06db24db954438ec2befa6aa62bbc2e91ec405db5b4c8411f29421bf647b0 is not valid. Provide a valid source image.: [email protected]

Current "dodgy" fix

remove digest from uri - so lambda essentially pulls latest container uploaded.
this is a bad fix since you cannot rollback to older versions and lose track of which specific container build is causing images.

Ideal solution

force use of specific container version - previously a digest was used.

Also realised there are language specific logic just for python containers.

MengLinMaker · 2026-03-02T22:25:27Z

Alright fix should be easy: interpolate${bootstrapData.assetEcrUrl}@${image.digest}`
This is the uri that should be used

MengLinMaker · 2026-03-03T10:18:04Z

@vimtor

I think the PR should be done now.

As for passing Image as a prop to Function to support containerised lambdas, there quite a few things to figure out:

How would dev work?
1.1 isContainer is true when args.dev is true (enabled) and $dev (cli dev) is true
How would you retain breakpoints feature?
How to handle conflicting inputs?
Should we pass Image into Function or uri?
4.1 Accommodate both?

// image.ts
interface ImageInterface = { uri: string }
export class Image extends Component implements Link.Linkable, ImageInterface {
  ...
}

// function.ts
image: ImageInterface

There's a lot of delicate logic.

MengLinMaker · 2026-03-03T20:51:10Z

I'm adding image compression options

MengLinMaker · 2026-03-04T01:53:06Z

To be tested again

vimtor · 2026-03-04T09:00:32Z

@MengLinMaker is it ready then? could you first fix the branch conflicts first so i don't miss anything when reviewing?

MengLinMaker · 2026-03-04T13:11:26Z

@vimtor Yep ready to review

vimtor

i'm going back to this again. sorry for the delay @MengLinMaker

can you update your changes with origin/dev? i believe we added secrets support in the deleted file

i've left some comments with issues i found and suggestions

my main concern is that, since we are replacing imageBuilder with a custom component, we will force a deletion + creation for existing images. not sure how much of a problem this is in practice, i need to investigate

vimtor · 2026-03-27T11:55:09Z

+    const region = getRegionOutput({}, opts).name;
+    const bootstrapData = region.apply((region) => bootstrap.forRegion(region));
+    // Empty uri should fail deployment if not set
+    this._uri = interpolate``


defining _uri like this feels prone to race conditions. we should find an alternative

@vimtor Sorry I don't quite understand the issue.

From what I understand, pulumi outputs needs to be "awaited" in Pulumi style: all(...).apply()

Are you saying that _uri may not be defined when get uri() is called?

Once the constructor is called, _uri should be defined before accessing

This problem should be solved now.

MengLinMaker · 2026-03-28T03:02:57Z

my main concern is that, since we are replacing imageBuilder with a custom component, we will force a deletion + creation for existing images. not sure how much of a problem this is in practice, i need to investigate

For Fargate tasks, the new image will also create a new Task Definition.

Even currently SST appears to be creating new images and Task Definitions for Fargate.

Not sure about Function, which is only used by python

MengLinMaker · 2026-04-20T11:50:26Z

+    // Empty uri should fail deployment if not set
+    this._uri = interpolate``
+
+    all([args, bootstrapData]).apply(


Apparently creating resources inside all(...).apply() will not log the image uri

Reference: https://www.pulumi.com/docs/iac/concepts/inputs-outputs/apply/?utm_source=chatgpt.com#accessing-single-outputs-with-apply

MengLinMaker · 2026-04-22T07:53:00Z

@vimtor, I've addressed the issues mentioned

straygar · 2026-06-12T12:46:21Z

Great change, looking forward to its release! 🙏 (also for AWS Batch tidiness)

chore: update vitest

fd174a0

MengLinMaker added 8 commits January 27, 2026 22:22

Revert "chore: update vitest"

1d2f245

This reverts commit fd174a0.

draft image component

0d5097f

prettier

43a7d80

export image

013b303

implement missing args

6b0929f

update sst to use latest

576bc66

add image digest mainly for internal use

8bf8856

refactor fargate to use new image component

b5a01dd

MengLinMaker marked this pull request as ready for review January 29, 2026 21:03

MengLinMaker mentioned this pull request Jan 30, 2026

Feat: SOCI indexing images for faster fargate bootup #6369

Open

MengLinMaker added 3 commits March 2, 2026 23:41

fix: add name prefix to prevent pulumi component name clash

e552538

refactor function to use new image component

844979d

fix: avoid flaky digest deploy issue with digestless and tagless imag…

60bc639

…e uri

MengLinMaker added 3 commits March 3, 2026 09:45

uri should be in ecr@digest format to use specific container version

5d5b26a

no idea what node() is used for

ef2cecd

fargate should use uri directly

2fa3000

MengLinMaker added 2 commits March 3, 2026 22:55

config to generate image doc page with tsdoc

a840d37

extract Platform type which could not be processed by doc generator

e8a69fa

vimtor mentioned this pull request Mar 3, 2026

Replace latest tag with component name in python docker Image #6004

Open

MengLinMaker added 3 commits March 3, 2026 23:25

remove unused variables

022506a

Record type can be doc generated

8d7752d

add examples to doc

7b84ec1

support image compression

974af5d

vimtor and others added 2 commits March 4, 2026 12:25

Handle assumeRoles array format from Pulumi AWS v7 (anomalyco#6522)

008fbc6

Merge branch 'dev' into feat-sst-image

ba01a21

R44VC0RP force-pushed the dev branch from 008fbc6 to f7a1c46 Compare March 4, 2026 13:58

doc: alternative SOCI indexing only supports gzip

547703e

MengLinMaker commented Mar 10, 2026

View reviewed changes

Comment thread platform/src/components/aws/image.ts Resolved

vimtor requested changes Mar 27, 2026

View reviewed changes

vimtor changed the title ~~feat: image component for both external and internal use~~ Add Image component for sharing images Mar 27, 2026

vimtor changed the title ~~Add Image component for sharing images~~ Add Image component for sharing Docker images Mar 27, 2026

MengLinMaker added 4 commits March 28, 2026 23:43

revert unecessary code changes

fea4451

Merge branch 'dev' into feat-sst-image

67b6e26

feat: pass parent ComponentResourceOptions

3aca4dd

remove image compression level option

59dbc57

MengLinMaker requested a review from vimtor April 20, 2026 10:43

remove unused variable

0550eea

MengLinMaker commented Apr 20, 2026

View reviewed changes

Comment thread platform/src/components/aws/image.ts Resolved

fix: solve _uri race condition issue

071d66e

Conversation

MengLinMaker commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MengLinMaker commented Jan 26, 2026

Uh oh!

vimtor commented Jan 26, 2026

Uh oh!

MengLinMaker commented Jan 26, 2026

Uh oh!

MengLinMaker commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vimtor commented Jan 27, 2026

Uh oh!

MengLinMaker commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MengLinMaker commented Feb 1, 2026

Uh oh!

vimtor commented Feb 27, 2026

Uh oh!

MengLinMaker commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress update 2026-03-03

Current "dodgy" fix

Ideal solution

Uh oh!

MengLinMaker commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MengLinMaker commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MengLinMaker commented Mar 3, 2026

Uh oh!

MengLinMaker commented Mar 4, 2026

Uh oh!

vimtor commented Mar 4, 2026

Uh oh!

MengLinMaker commented Mar 4, 2026

Uh oh!

Uh oh!

vimtor left a comment

Choose a reason for hiding this comment

Uh oh!

vimtor Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

MengLinMaker Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

MengLinMaker Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MengLinMaker commented Mar 28, 2026

Uh oh!

MengLinMaker Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MengLinMaker commented Apr 22, 2026

Uh oh!

straygar commented Jun 12, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

MengLinMaker commented Jan 26, 2026 •

edited

Loading

MengLinMaker commented Jan 27, 2026 •

edited

Loading

MengLinMaker commented Jan 29, 2026 •

edited

Loading

MengLinMaker commented Mar 2, 2026 •

edited

Loading

MengLinMaker commented Mar 2, 2026 •

edited

Loading

MengLinMaker commented Mar 3, 2026 •

edited

Loading