Repository navigation
Windows support - #5256
Merged
Merged
Windows support#5256
Conversation
Member
|
wow this is great thanks for doing this need to spend some time looking over it but on first glance looks great - maybe will land on 2 or 3 |
|
Is there a way others can help on this? Would be nice to get this PR merged (as beta or whatever) and then work on porting over feature per feature in seperate issues to lighten the load? |
thdxr
force-pushed
the
dev
branch
2 times, most recently
from
January 30, 2025 06:27
d187b0a to
9ec92b5
Compare
thdxr
force-pushed
the
feat/windows-support
branch
from
April 3, 2025 15:43
bb43fe8 to
3489b47
Compare
…matting in InstallBun function
…ulumiPath for Windows compatibility
… with forward slashes in input code
…ators to forward slashes for compatibility with embed.FS
thdxr
force-pushed
the
feat/windows-support
branch
from
April 28, 2025 15:06
3489b47 to
1b40112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a stab at this over the weekend—there’s still work to do, but I wanted to create this PR for visibility and confirm it’s aligned with expectations before proceeding (@jayair / @thdxr). I’ve developed and tested this on Windows and spun a Linux instance to confirm changes are not breaking (via a Docker container, which I haven’t committed but may be useful for future testing).
I got
go build ./cmd/sst && ./sst(.exe) dev&go run ../../cmd/sst devto work without errors against cloudflare-hono & aws-api examples up until it asks for credentials (used creds for Cloudflare but not AWS). Pending is furtherdevtesting (tunnel, etc), supporting other commands and build/release pipeline for Windows.Where do we go from here?