feat(DiffRenderable): synchronize scroll between split view panes in diff.ts#742
Conversation
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
|
Thanks for taking a stab at this. If i understand the impl right you changed the behavior to always be "synced"? |
|
@simonklee , yes I have changed it to always sync, um, like everywhere else we see. If you want I can have a hotkey based toggle between both separate/synced behaviours too. |
I understand, but this is effectively just changing the behavior of a design decision made by @kommander. See his comment in the original issue:
So, to land this PR, that should be addressed. |
|
Yes, I read it, but for starters I did the change. |
|
Yeh, something like that. An option on the DiffRenderable that defaults to the current behavior. |
Hey @simonklee , made the changes, added the option in the API as syncScroll, false by default to keep the current behaviour. can be set to true to make it synced. |
Fixes: #563
Hi @kommander and @simonklee,
Added this synced scroll in code diff as mentioned in this issue...
I was thinking to keep both separate and synced scroll which can be toggled through hotkeys depending on user preferences.
Whatever you guys say 😄
opentui4.mov