Repository navigation
Fix node using itself as anchor resulting in incorrect ordering - #552
Merged
Merged
Conversation
Adictya
requested review from
Hona,
fezproof,
kommander and
msmps
as code owners
January 19, 2026 12:38
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
Adictya
changed the title
Adictya
changed the title
bresilla
added a commit
to bresilla/opentui
that referenced
this pull request
Jan 23, 2026
* upstream/main: Fix node using itself as anchor resulting in incorrect ordering (anomalyco#552) chore(core): add Code and ScrollBox construct helpers (anomalyco#565) fix(react): share app context across build entrypoints (anomalyco#571) feat(core): add SIGPIPE, SIGBUS, SIGFPE to default exit signals (anomalyco#547) fix(react/solid): add missing markdown element (anomalyco#569)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where if the node itself is provided to insertBefore as anchor as well, the node gets inserted at the wrong index.
Issue got noticed in a testcase of reversing an array in solid and trigerring a re-render which didn't result in the correct item order.
Tests included at both core and solid level
Also makes non existing anchor a non fatal error.