Repository navigation
fix(OSC4): tmux 3.6 has native support for OSC4 and should not be wrapped - #373
Merged
Merged
Conversation
Contributor
|
Ohhh tmux was updated last week, this explains my confusion! I introduced that bug my bad! |
Contributor
Author
|
It's OK: I did my first OpenCode/OpenTUI contrib and I've learned about OSC sequences 😉 |
msmps
pushed a commit
that referenced
this pull request
Jan 8, 2026
…pped (#373) #354 fix was only working for tmux<3.6 because it doesn't have native OSC4 support, so OSC4 sequence needed escaping. But, tmux 3.6 has native OSC4 support and wrapping the sequence in a tmux escape prevent OSC4 to work with tmux 3.6. This fixes anomalyco/opencode#3688 for tmux 3.6 (regression was introduced by upgrading to OpenTUI 0.1.51 in anomalyco/opencode@204a31b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#354 fix was only working for tmux<3.6 because it doesn't have native OSC4 support, so OSC4 sequence needed escaping.
But, tmux 3.6 has native OSC4 support and wrapping the sequence in a tmux escape prevent OSC4 to work with tmux 3.6.
This fixes anomalyco/opencode#3688 for tmux 3.6 (regression was introduced by upgrading to OpenTUI 0.1.51 in anomalyco/opencode@204a31b.