Repository navigation
feat(terminal-palette): add tmux OSC sequence passthrough support - #354
Merged
Merged
Conversation
melMass
commented
Nov 27, 2025
melMass
commented
Contributor
- wrap OSC sequences for tmux using DCS format (ESC P tmux; ...)
- detect tmux environment and automatically wrap sequences when needed
- consolidate OSC writes through new writeOsc() method for cleaner passthrough handling
- wrap OSC sequences for tmux using DCS format (ESC P tmux; ...) - detect tmux environment and automatically wrap sequences when needed - consolidate OSC writes through new writeOsc() method for cleaner passthrough handling
kommander
reviewed
Nov 27, 2025
| /** | ||
| * Check if running inside tmux | ||
| */ | ||
| function isTmux(): boolean { |
Collaborator
There was a problem hiding this comment.
Could it use renderer.capabilities here?
Contributor
Author
There was a problem hiding this comment.
I didn't know about it, I moved it to the renderer and tested it still works
Instead of checking process.env.TMUX directly in TerminalPalette, accept isTmux as constructor parameter. Renderer now passes tmux detection from capabilities or env var.
melMass
force-pushed
the
fix-tmux-osc
branch
from
November 27, 2025 22:38
3a8ea12 to
c2e2b7b
Compare
kommander
approved these changes
Nov 27, 2025
kommander
left a comment
kommander
left a comment
Collaborator
There was a problem hiding this comment.
I would like to have this test covered, but it doesn't seem to break existing behaviour according to the tests at least. Can add test coverage afterwards then.
This was referenced Nov 30, 2025
kommander
pushed a commit
that referenced
this pull request
Dec 2, 2025
…pped (#373) #354 fix was only working for tmux<3.6 because it doesn't have native OSC4 support, so OSC4 sequence needed escaping. But, tmux 3.6 has native OSC4 support and wrapping the sequence in a tmux escape prevent OSC4 to work with tmux 3.6. This fixes anomalyco/opencode#3688 for tmux 3.6 (regression was introduced by upgrading to OpenTUI 0.1.51 in anomalyco/opencode@204a31b.
msmps
pushed a commit
that referenced
this pull request
Jan 8, 2026
msmps
pushed a commit
that referenced
this pull request
Jan 8, 2026
…pped (#373) #354 fix was only working for tmux<3.6 because it doesn't have native OSC4 support, so OSC4 sequence needed escaping. But, tmux 3.6 has native OSC4 support and wrapping the sequence in a tmux escape prevent OSC4 to work with tmux 3.6. This fixes anomalyco/opencode#3688 for tmux 3.6 (regression was introduced by upgrading to OpenTUI 0.1.51 in anomalyco/opencode@204a31b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.