Repository navigation
fix(core): Preserve empty lines when copying selected text - #1103
Merged
Merged
Conversation
benkoppe
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
May 22, 2026 13:02
benkoppe
changed the title
Contributor
Author
|
This issue seems to be cited in Opencode multiple times: anomalyco/opencode#10098 |
Contributor
Author
|
Thanks so much @kommander , can't tell you how much this will improve my workflow! |
This was referenced Jun 2, 2026
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTUI currently completely drops empty logical lines from selected text. This means highlight-copying code can remove intentional blank lines, which often breaks formatting.
This affects Opencode heavily, making copying/pasting code excessively annoying because all blank lines are completely erased.
The behavior was caused by
extractTextBetweenOffsets. Newline output was gated on whether the line had content, therefore empty selected lines never emitted their newline. This PR changes newline emission to be based on whether the newline offset is inside the selected range, regardless of line content.Includes a regression test for:
copying back exactly as selected.