Repository navigation
Conversation
3 of 6 tasks
Collaborator
Author
|
This moved to the monorepo as anomalyco/opencode#59702 (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listener::waitstub insrc/transport/windows.rsnow sleeps up to 25 ms instead of 10 ms (POLL_INTERVAL).src/service/windows.rsnow polls every 25 ms instead of 10 ms (EXIT_POLL_INTERVAL).transport/mod.rsdoc, and the code comments now say 25 ms.waitcallWaitForMultipleObjectson the pending connect event plus a stop event, and have each terminal block inWaitForSingleObjecton its process handle.src/daemon/server.rstiming tests are Unix-only, so no test needed changing.Validation
cargo fmt --checkandcargo clippy --locked --all-targets --all-features -- -D warningspass (toolchain 1.90.0).cargo test --locked --lib --test service --test runtime --test ownership --test rows --test ghostty-effects(lib 59, ghostty-effects 5, ownership 8, rows 1, runtime 8 + 1 ignored, service 9).-D warningspasses forx86_64-pc-windows-msvcandx86_64-unknown-linux-gnu(--all-targets --all-features, ghostty-vt link libs stubbed). Native Windows and Linux are verified by CI.