Repository navigation
Replaced unzip with PowerShell on Windows - #974
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Co-authored-by: thdxr <[email protected]>
Member
|
hey opencode super ugly - can we just switch to native unzip in js? |
andreipromarketing-dev
pushed a commit
to andreipromarketing-dev/opencode
that referenced
this pull request
Apr 7, 2026
…heck-persistent-instructions fix(codex): add persistent_instructions to baseline and relax sanity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have successfully implemented the requested feature to replace external
unzipdependency with PowerShell's built-in extraction capabilities for Windows systems. Here's what was accomplished:Changes Made:
ripgrep.ts (
packages/opencode/src/file/ripgrep.ts:164-175):Bun.spawn(["unzip", "-j", archivePath, "*/rg.exe", "-d", Global.Path.bin])with PowerShell'sSystem.IO.Compression.ZipFileAPIunzipon non-Windows platformsfzf.ts (
packages/opencode/src/file/fzf.ts:82-94):Bun.spawn(["unzip", "-j", archivePath, "fzf.exe", "-d", Global.Path.bin])with PowerShell extractionunzipon non-Windows platformslsp/server.ts (
packages/opencode/src/lsp/server.ts:195and296-300):unzip -o -qwith PowerShell'sExpand-Archivecmdletunzipon non-Windows platformsTechnical Implementation:
System.IO.Compression.ZipFileAPI through PowerShell to extract individual files from zip archivesExpand-Archivecmdlet for extracting entire archivesunzipcommands on non-Windows platformsBenefits:
choco install unzipon Windows systemsunzipas beforeThe implementation addresses the exact issue described - replacing external
unzipusage with PowerShell's native capabilities while maintaining full backward compatibility and functionality.Closes #967
view session | view log