Repository navigation
fix: correct dot prefix display in directory names for RTL text rendering issue #9579 - #9591
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #9586: "fix: correct dot prefix display in file paths for directories starting with dots" Why it's related: This PR addresses the exact same issue - dot prefixes in directory names being incorrectly displayed in file paths. Both PRs appear to be fixing the same bug in the Session Review/changes panel where dots from directory names (like |
There was a problem hiding this comment.
Pull request overview
This PR fixes a text rendering bug where dot prefixes from directory names were incorrectly appearing on filenames in the Session changes panel due to the Unicode Bidirectional Algorithm being triggered by CSS direction: rtl. The fix wraps directory paths with Unicode Left-to-Right Embedding (\u202A) and Pop Directional Formatting (\u202C) characters to prevent character reordering while maintaining the left-truncation behavior.
Changes:
- Replaced
‎(Left-to-Right Mark) with Unicode LRE/PDF wrapping in directory path display - Applied fix to Session Review and Session Turn components
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui/src/components/session-turn.tsx | Wrapped directory path with Unicode LRE/PDF to fix dot reordering in session turn display |
| packages/ui/src/components/session-review.tsx | Wrapped directory path with Unicode LRE/PDF to fix dot reordering in session review display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div data-slot="session-review-file-name-container"> | ||
| <Show when={diff.file.includes("/")}> | ||
| <span data-slot="session-review-directory">{getDirectory(diff.file)}‎</span> | ||
| <span data-slot="session-review-directory">{`\u202A${getDirectory(diff.file)}\u202C`}</span> |
There was a problem hiding this comment.
The same RTL text rendering issue exists in message-part.tsx at lines 990 and 1039, where getDirectory is used with the same CSS direction: rtl styling. These locations also display directory paths with dots that could be reordered by the Unicode Bidirectional Algorithm. Consider applying the same Unicode Left-to-Right Embedding fix to these locations for consistency.
…ring issue #9579 (#9591)
Fixes file path display bug where dot prefixes from directory names (e.g.,
.opencode/) were incorrectly appearing on filenames in the Session changes panel.Problem:
.opencode/commands/README.mdopencode/commands/.README.md(dot moved from directory to filename)Root Cause:
CSS
direction: rtl(used for left-truncation of long paths) triggers Unicode Bidirectional Algorithm, which treats dots as neutral characters and reorders them visually.Solution:
Wrapped directory paths with Unicode Left-to-Right Embedding (
\u202A) and Pop Directional Formatting (\u202C) to isolate the directory text and prevent character reordering while preserving left-truncation behavior.Files Changed:
packages/ui/src/components/session-review.tsx- Session Review panelpackages/ui/src/components/session-turn.tsx- Session Turn displayCloses #9579