Repository navigation
fix(tui): prevent crash in theme dialog when filter yields no results - #8879
Closed
renormalize wants to merge 1 commit into
Closed
renormalize wants to merge 1 commit into
renormalize wants to merge 1 commit into
Conversation
* Add guard clause in `onMove` callback to check if option exists before accessing its properties. Signed-off-by: Saketh Kalaga <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
opencode-agent
Bot
force-pushed
the
dev
branch
from
January 30, 2026 14:32
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
January 30, 2026 14:37
f1ae801 to
08fa7f7
Compare
Author
|
Superseded by #10565. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8873
Add guard clause in
onMovecallback to check if option exists before accessing its properties.AI disclosure: I used opencode with Claude to figure out what was causing the error in the release (1.1.23, latest as of writing) of opencode I was running. I barely have any JS/TS knowledge, and it guided me to this solution.
If this is not the correct approach to solving this bug, and the maintainers would like to change things elsewhere to prevent this, please let me know and I am more than happy to learn and incorporate their feedback.
How did you verify your code works?
./packages/opencode/script/build.ts --singleto build "localcode" with the change I made../packages/opencode/dist/opencode-darwin-arm64/bin/opencodeto start opencode.sonokai.1.1.23when I typedn.