fix: Add Plugin Mocks to Provider Tests #8276
Merged
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify GitLab Duo provider implementation following code review: - Move @gitlab/[email protected] to BUILTIN array (like Copilot/Anthropic) - Make @gitlab/[email protected] opt-in (not auto-loaded) - Remove custom GitLab plugin detection logic (~33 lines) - Simplify auth to use Auth.get() instead of manual parsing (~45 lines) - Remove unused imports (path, os) from provider.ts - Add plugin mocks to all provider tests to prevent installation timeouts Net code reduction: 63 lines All 660 tests passing
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
@rekram1-node I've introduced some tests degradation recently, after GitLab provider PR has been merged. This fixes the tests. |
fwang
pushed a commit
that referenced
this pull request
Jan 14, 2026
shuv1337
added a commit
to Latitudes-Dev/shuvcode
that referenced
this pull request
Jan 14, 2026
Upstream changes: - feat: add plan mode with enter/exit tools (anomalyco#8281) - feat: Add GitLab Duo Agentic Chat Provider Support (anomalyco#7333) - feat(desktop): Ask Question Tool Support (anomalyco#8232) - feat: add Undertale and Deltarune built-in themes (anomalyco#8240) - fix: Add Plugin Mocks to Provider Tests (anomalyco#8276) - fix: update User-Agent string to latest Chrome version in webfetch (anomalyco#8284) - fix(prompt-input): handle Shift+Enter before IME check - fix(state): delete key from recordsByKey on instance disposal - fix(mcp): close existing client before reassignment to prevent leaks Resolved conflicts: - bun.lock: regenerated with fork dependencies - global-sync.tsx: adopted upstream variable naming (question instead of request) - session/index.tsx: merged upstream workdir display with fork's ANSI terminal emulation - amazon-bedrock.test.ts: added all mock modules (fork + upstream) - vscode/package.json: kept fork branding, updated version Fork commits included: - refactor(tui): use SDK client for tool list dialog - chore: update lockfile with fork dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing plugin mocks to provider.test.ts to prevent test timeouts. After moving GitLab auth plugin to the BUILTIN array, all provider tests need to mock builtin plugins to prevent actual package installation attempts during test runs.
Problem
The test "provider loaded from env variable" was timing out (5000ms) because:
Solution
Added comprehensive mocks to provider.test.ts: