fix(prompt-input): handle Shift+Enter before IME check to prevent stuck state #8275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related issues with newline input in the prompt:
input_newlinekeybind was defined in config but never used; only Shift+Enter was hardcodedProblem
Issue 1: Keybinds not implemented
The config defines
input_newline: 'shift+return,ctrl+return,alt+return,ctrl+j'but the code only checked forevent.shiftKey && event.key === 'Enter'. This meant Ctrl+J and other alternatives never worked.Issue 2: IME composing state gets stuck
The IME composing check ran before the newline handler. If the
composingsignal got stuck intruestate (e.g., ifcompositionendevent never fired), all Enter keypresses were ignored.This manifests as:
Solution
parseKeybind/matchKeybindand use the config'sinput_newlinekeybind instead of hardcodingTesting