-
Notifications
You must be signed in to change notification settings - Fork 5.9k
feat(desktop): Ask Question Tool Support #8232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found related PRs that are in the same feature area but are not exact duplicates of PR #8232: Potentially Related PRs:
PR #8232 appears to be specifically for desktop support while these other PRs target web and TUI. They're related features but address different platforms, so they're not exact duplicates. |
|
Wow, I really miss this coming from Claude Code |
Upstream changes: - feat: add plan mode with enter/exit tools (anomalyco#8281) - feat: Add GitLab Duo Agentic Chat Provider Support (anomalyco#7333) - feat(desktop): Ask Question Tool Support (anomalyco#8232) - feat: add Undertale and Deltarune built-in themes (anomalyco#8240) - fix: Add Plugin Mocks to Provider Tests (anomalyco#8276) - fix: update User-Agent string to latest Chrome version in webfetch (anomalyco#8284) - fix(prompt-input): handle Shift+Enter before IME check - fix(state): delete key from recordsByKey on instance disposal - fix(mcp): close existing client before reassignment to prevent leaks Resolved conflicts: - bun.lock: regenerated with fork dependencies - global-sync.tsx: adopted upstream variable naming (question instead of request) - session/index.tsx: merged upstream workdir display with fork's ANSI terminal emulation - amazon-bedrock.test.ts: added all mock modules (fork + upstream) - vscode/package.json: kept fork branding, updated version Fork commits included: - refactor(tui): use SDK client for tool list dialog - chore: update lockfile with fork dependencies
|
@offlinehacker yeah i did some quick search before work on it but didn't find for some reason, only saw later on when the dupe PR commented... anyway, yours looked pretty good too... Feel free to open a PR following up what you think it's missing... But i would try to ask the team first on the discord... Tag adam, because making navigation would mean removing focus from prompt, feels a new thing, which sounds good anyway... |
What does this PR do?
Adds support on desktop, following a similar experience than TUI, but also matching the Permission behavior on desktop
How did you verify your code works?