fix: app_exit keybind ignored when using <leader> (including default <leader>q)#8151
Open
razor-x wants to merge 1 commit intoanomalyco:devfrom
Open
fix: app_exit keybind ignored when using <leader> (including default <leader>q)#8151razor-x wants to merge 1 commit intoanomalyco:devfrom
razor-x wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
razor-x
force-pushed
the
fix-leader-quit
branch
from
a213b50 to
9f0418a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3851
What does this PR do?
Summary
Why this fixes it
How did you verify your code works?
Built and ran locally, verified q exits the app as expected.
I was not able to find a way to add an test for this. The core issue depends on the
app.tsxrunning and focus passing between the prompt an the app, so a unit test is mostly ceremonial. An e2e test would require a net test harness to mount the TUI app similar to how playwright e2e works.