fix(tui): prevent question tool keybindings when dialog is open #8147
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QuestionPrompt component captures H/L keys for tab navigation, which conflicts with typing in the command palette when opened via Ctrl+P. This change adds a guard to skip keyboard event processing when a dialog is open, following the established pattern used in dialog-command.tsx. Fixes anomalyco#8118 Co-Authored-By: Claude <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
thanks boss @zerone0x |
sauerdaniel
pushed a commit
to sauerdaniel/opencode
that referenced
this pull request
Jan 13, 2026
…alyco#8147) Co-authored-by: Claude <[email protected]>
dl-alexandre
pushed a commit
to dl-alexandre/opencode
that referenced
this pull request
Jan 13, 2026
…alyco#8147) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the keyboard binding conflict where the Question tool's H/L navigation keys interfere with typing in the command palette.
When the Question tool is active and the user opens the command palette (Ctrl+P), pressing
horlwould navigate the question tabs instead of typing in the command palette's search input.This change adds a guard at the start of the
useKeyboardhandler to skip event processing when a dialog is open, following the established pattern used indialog-command.tsx(lines 48 and 103).Fixes #8118
How did you verify your code works?
dialog-command.tsxdialogcontext fromuseDialog()dialog.stack.length > 0before processing🤖 Generated with Claude Code