fix(task): respect agent task permission for nested sub-agents #8111
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found several related PRs that address similar concerns around task tool permissions and sub-agent functionality: Potentially Related PRs:
These PRs all touch on the intersection of agent permissions, task tools, and sub-agent functionality. You may want to review them to ensure your fix doesn't conflict with or duplicate any ongoing work in these areas. |
The permission rework in anomalyco#6319 removed the ability to override the default task tool restriction via agent frontmatter. This fix checks if the agent has any task permission rule defined. If so, we don't add our default deny - letting the agent's permission take effect. If not specified, the default deny behavior is preserved.
malhashemi
force-pushed
the
fix/restore-nested-subagent-permission
branch
from
3b361db to
94eb30b
Compare
malhashemi
changed the title
2 participants
Fixes #8114
What does this PR do?
Restores the ability for agents to control the task tool via permission frontmatter.
The permission rework in #6319 removed the
...agent.toolsspread that allowed agents to override the defaulttask: false. This fix checks if the agent has any task permission rule defined - if so, we don't add our default deny, letting the agent's permission take effect.Examples:
permission: { task: allow }→ can spawn any sub-agentpermission: { task: { researcher: allow } }→ can only spawn researcherpermission: { task: deny }→ explicitly deniedHow did you verify your code works?
bun test task- 21 tests passbun test permission- 82 tests pass