fix: support plural directory names in command/agent name extraction #7668
+70
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b9ef09a added glob pattern support for plural directory names (commands/, agents/) but did not update the name extraction logic. This caused nested command/agent names to lose their prefix when using plural directory names. For example, when using OPENCODE_CONFIG_DIR pointing to a custom config directory with structure `commands/email/digest.md`: - Expected: email/digest - Actual (before fix): digest This fix adds plural patterns to the name extraction logic: - For commands: adds "/.opencode/commands/" and "/commands/" - For agents: adds "/.opencode/agents/" and "/agents/" Also added test cases to verify nested commands/agents in plural directories preserve their path prefix. Ref: b9ef09a Signed-off-by: Meng Yan <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Meng Yan <[email protected]>
yanmxa
force-pushed
the
fix/plural-command-agent-patterns
branch
from
32ecd30 to
02f3308
Compare
Author
Collaborator
|
yeah sorry, I didn't remember this one. Note that our issue and PR volume is getting insanely large so Im having a hard time keeping up and keeping track of all of these. my bad |
Author
|
No worries @rekram1-node, totally understand! Managing a fast-growing project with high volume of issues and PRs is challenging work. Thanks for the response and for all the effort you put into this project. Looking forward to contributing more in the future! (Closing the related issue #7667 as well since it's been resolved.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7667
Commit b9ef09a added glob pattern support for plural directory names (
commands/,agents/) but did not update the name extraction logic. This caused nested command/agent names to lose their prefix when using plural directory names.Changes
/.opencode/commands/,/commands/,/.opencode/agents/,/agents/) to the name extraction logic inloadCommandandloadAgentfunctionsTest Plan
commands/directoryagents/directoryExample
When using
OPENCODE_CONFIG_DIRwith structurecommands/email/digest.md:digest(prefix lost)email/digest(prefix preserved)