refactor: session settings simplification #7342
Merged
+21
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the session settings to use `kv.signal` instead of wrapped `kv.get` calls, eliminating the need for manual `kv.set` calls.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
maxstevens-nl
changed the title
Collaborator
|
/review |
Contributor
|
lgtm |
thdxr
pushed a commit
that referenced
this pull request
Jan 8, 2026
8 tasks
aryasaatvik
pushed a commit
to aryasaatvik/opencode
that referenced
this pull request
Jan 10, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the session settings to use
kv.signalinstead of wrappedkv.getcalls, eliminating the need for manualkv.setcalls.I also fixed a small kv.signal bug by checking only for undefined; previously, any falsy value would cause the key to reset to its default.