fix(theme): add selectedListItemText to orng themes for button text visibility #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isibility Fixes anomalyco#6849 The orng and lucent-orng themes were missing the selectedListItemText property, causing button text in permission dialogs to use the background color (black in dark mode) which is invisible against the orange button background. This adds explicit selectedListItemText values: - Dark mode: #0a0a0a (black) for contrast on orange - Light mode: #ffffff (white) for contrast on lighter orange
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6849
The
orngandlucent-orngthemes were missing theselectedListItemTextproperty, causing button text in permission dialogs to be invisible.Problem
When using the
orngtheme, the permission dialog buttons have invisible text because:primarycolor (orange#EC5B2B)backgroundcolor (black#0a0a0ain dark mode)Solution
Added explicit
selectedListItemTextvalues to both theme files:#0a0a0a(black) - provides good contrast on orange background#ffffff(white) - provides good contrast on lighter orangeFiles Changed
packages/opencode/src/cli/cmd/tui/context/theme/orng.jsonpackages/opencode/src/cli/cmd/tui/context/theme/lucent-orng.jsonTesting
Manual testing required:
orng