fix: use actual version in install script #7044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll script Replace hardcoded '0.0.1' with call to 'opencode --version' in check_version() function. This fixes the TODO comment on line 212 and prevents unnecessary reinstallations when the same version is already installed.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Duplicate PR Search ResultsNo duplicate PRs found. The search results show:
The other results are unrelated PRs about TUI layout, OpenTelemetry, Docker, and subagent sessions. Conclusion: PR #7044 appears to be addressing a unique issue (using actual installed version instead of hardcoded value in the version check function). While PR #6498 also improves the install script, it focuses on PATH handling, which is distinct from the version checking concern in PR #7044. |
Collaborator
|
/review |
Contributor
|
lgtm |
ruuxi
pushed a commit
to ruuxi/ngmicode
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The install script has a TODO comment on line 212 indicating the version check should use the actual installed version instead of a hardcoded value.
Solution
Changed the
check_version()function to callopencode --versioninstead of using a hardcoded version.