fix(desktop): desktop won't read project scope commands/skills #6963
+338
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace stack-based nested call tracking with simpler local variable - Replace manual release/chained lock with promise queue pattern - Extract getDirectory helper in server.ts to reduce duplication - Use fs.exists() instead of fs.stat().then() pattern in config.ts
Tests cover: - Running functions in specified directory - Directory restoration after execution - Skip optimization when already in target directory - Error handling with proper cleanup - Nested call handling - Concurrent call serialization - Async function support - Deeply nested directory changes
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Duplicate Search ResultsNo duplicate PRs found. The search queries returned only the PR mentioned in your file (PR #6963: "fix(desktop): desktop won't read project scope commands/skills"), which is the current PR being checked. I searched using multiple relevant terms:
All searches confirm there are no other open PRs addressing the same desktop project scope issue. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue on desktop where project-scoped commands, skills, and configurations were not being loaded when switching between projects. The root cause was that only a single project instance was created and reused across different directories without rebuilding.
Key changes:
- Added
ProcessCwdutility to safely manageprocess.cwd()changes with proper serialization for concurrent calls and restoration on completion - Wrapped project instance creation and execution with
ProcessCwd.run()to ensure correct working directory context - Wrapped tool execution in server endpoints with
Instance.provide()to guarantee proper project context - Added support for loading commands from
.claude/commands/directories for Claude Desktop compatibility - Enhanced desktop-specific project identification using directory hashing for non-git directories
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/opencode/src/util/process-cwd.ts | New utility to safely manage process.cwd() changes with concurrency control and nested call support |
| packages/opencode/test/util/process-cwd.test.ts | Comprehensive test suite for ProcessCwd utility covering edge cases |
| packages/opencode/src/project/instance.ts | Integrated ProcessCwd.run() to ensure tool execution happens in correct working directory context |
| packages/opencode/src/project/project.ts | Added desktop-specific project identification using directory hashing for non-git directories |
| packages/opencode/src/config/config.ts | Added support for loading commands from .claude/commands/ directories |
| packages/opencode/src/server/server.ts | Extracted getDirectory helper and wrapped prompt endpoints with Instance.provide for proper project context |
| packages/opencode/src/session/prompt.ts | Wrapped tool execution with Instance.provide to ensure commands/skills are loaded from correct project |
| packages/opencode/src/tool/skill.ts | Fixed error message to properly display available skills using map instead of Promise |
| packages/app/src/context/permission.tsx | Refactored directory decoding logic to avoid redundant operations (contains bug) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 5, 2026
Directory is now passed directly without base64 encoding, simplifying the permission check logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: on desktop, no project setup will read(project scope commands/skills etc.).
Root cause: only one project instance created, won't rebuild when switching project.
Solution: added ProcessCwd utility to safely manages process.cwd() changes. And wrap some process in Instance.provide to make sure use right project instance.