Skip to content

fix: prevent main model thinking variant from applying to small model - #6839

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
melihmucuk:fix/small-model-thinking-variant
Jan 4, 2026
Merged

rekram1-node merged 1 commit into
anomalyco:devfrom
melihmucuk:fix/small-model-thinking-variant

Conversation

@melihmucuk

Copy link
Copy Markdown
Contributor

Summary

When changing thinking level (ctrl+t) for the main model, the selected variant (e.g., reasoningEffort) was incorrectly applied to small model calls (title/summary generation). This caused API errors when the small model didn't support the parameter.

Problem

small=true agent=title params={"options":{"reasoningEffort":"low"}}
ERROR "Model grok-code does not support parameter reasoningEffort."

The variant from input.user.variant was applied regardless of whether small: true was set.

Fix

Skip variant application when small: true in llm.ts:

// Before
const variant = input.model.variants && input.user.variant ? input.model.variants[input.user.variant] : {}
// After
const variant = !input.small && input.model.variants && input.user.variant ? input.model.variants[input.user.variant] : {}

@rekram1-node
rekram1-node merged commit 554572b into anomalyco:dev Jan 4, 2026
4 of 5 checks passed
@melihmucuk
melihmucuk deleted the fix/small-model-thinking-variant branch January 4, 2026 21:37
triklozoid pushed a commit to triklozoid/opencode that referenced this pull request Feb 2, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
meSingh pushed a commit to meSingh/opencode that referenced this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants