Repository navigation
Conversation
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
The move of the bounded session index into runtime/server looks behaviour-neutral. The query key is still ["home-sessions", conn], so the cache is the same one as before. The 500-row request and per-directory retention are unchanged, and every caller was updated. I checked this by reading the diff, running the moved index tests and data.test.ts (12/12 pass) and the app's tsc -b (passes). The 3 titlebar test failures also happen on the base branch.
Public API: unchanged (internal app modules only).
The main concern is the new loaded-session inventory (details inline):
- Nothing in this PR reads it, and
filterRemovedandSessionInventoryare unused too. For a split whose parts should each stand alone, I'd drop these and add them in the PR that uses them. - The way it's cached would make it unreliable for that follow-up.
Related: #55301
There was a problem hiding this comment.
The new commit addresses my earlier points: the inventory cache write, the QueryClient parameter, filterRemoved and SessionInventory are gone. The PR is now only the module move and renames, with callers and tests updated. The query (key ["home-sessions", conn], cache lifetime, 500-row request, per-directory retention) matches the base. I ran the index, data and sidebar-session tests (22 pass) and the app's tsc -b (passes). Public API: unchanged (internal app modules only). No further concerns.
|
Could a maintainer please approve the pending fork CI workflows for this PR? The required checks are waiting for approval ( |
|
Thanks, confirmed at 739ac31:
I have nothing further on these threads. |
Issue for this PR
Part 1 of the split requested in #60867; design context: #60241.
Type of change
What does this PR do?
Move the bounded session index and query from Home into
runtime/server, with neutral names shared by Home, Side tabs, Inbox helpers and recently closed tabs. Preserve the existing array result, query key/cache lifetime, 500-root-session request and per-directory retention.Following review, defer the loaded-session inventory and its deletion projection to the follow-up that actually consumes them. This PR now contains only the module moves, renamed symbols and updated callers/tests.
How did you verify your code works?
On this branch:
bun run check(33 tasks),bun run lint:changed upstream/dev, appbun run typecheck:tsc, 12 index/deletion tests repeated ten times, and all 80 Chromium Home/tabs regressions without retries.Windows validation uses an equivalent temporary import for the repository's
custom-elements.d.tssymlink; it is not committed. Upstream fork CI awaits maintainer workflow approval (action_required).Checklist
Added by the opencode bot (AI-generated).
Related: #55301