Repository navigation
Conversation
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. I ran the #46187 repro script against both checkouts from source. On the base branch, adding an unresolvable origin to wellknown:sources makes login to the healthy example server fail with Integration not found. With this change it still resolves (Available: login). The new test fails on the base branch and passes here. The wellknown and config tests pass, and typecheck:tsc for packages/core passes.
Public API is unchanged: this only changes how WellKnown.load/refresh handle a source that fails and has no cached manifest.
No concerns.
Related: #59320
fe28e0f to
22fed85
Compare
There was a problem hiding this comment.
This push only rebases the branch onto the latest dev, and the change is the same as before. I re-ran the #46187 repro on the rebased branch. The healthy origin still resolves when an unreachable source is listed, while dev still reports Integration not found. The well-known tests and the packages/core type check (typecheck:tsc) pass. The public API is unchanged, and I have no new concerns.
Issue for this PR
Closes #46187
Type of change
What does this PR do?
If one well-known source is unreachable and has no cached manifest, loading every source fails, so all well-known integrations and their remote config disappear after a restart and login reports "Integration not found" for a healthy origin. Now an unreachable source is logged and skipped, on both startup and the periodic refresh, and the other sources load normally. Sources with a cached manifest still fall back to it as before.
How did you verify your code works?
Logged in to the example well-known server with an unresolvable origin added to the saved sources, in throwaway data dirs. On dev the healthy origin is "Integration not found"; on this branch it resolves. Added a regression test; typecheck and the well-known and config tests pass.
Checklist
Added by the opencode bot (AI-generated).
Related: #59320