fix(ai): preserve explicit traceparent in HTTP requests by siglp · Pull Request #61386 · anomalyco/opencode

siglp · 2026-11-03T11:30:28Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Effect's HTTP client overwrites an existing traceparent header with its own trace context and may also add a B3 header from a different trace. This breaks trace correlation when a plugin injects its own trace context through request middleware.

The fix disables Effect's automatic trace propagation for requests that already contain a traceparent header. Requests without an explicit traceparent continue using the default behavior.

How did you verify your code works?

Built OpenCode locally and tested the complete tracing setup with:

OpenCode 2.2.4
AgentGateway 1.6.0
Langfuse 4.71.0
Modified Langfuse OpenCode observability plugin

Verified trace context propagation through OpenCode, AgentGateway and Langfuse.

Also added an integration test using a local HTTP server to verify the actual outgoing headers, including middleware-injected headers.

Full packages/ai test suite: 2,035 passed, 28 skipped, 0 failed.

All 35 pre-push checks passed.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

opencodejr

The fix works. I ran the new test against the base branch: it fails there because Effect replaces the explicit traceparent with its own. With this change, test/executor.test.ts passes and typecheck:tsc is clean. I also checked Effect 4.1.0's client: the propagation setting is read inside the per-request effect that HttpClient.transform wraps, and header names are lowercased. So the check sees headers added by middleware, and turning propagation off applies to that request only.

Public API is unchanged. The only change in behaviour: a request that already has a traceparent no longer gets Effect's traceparent or b3 headers.

One request: the new test is large for a 9-line fix. Please cut it to the core cases (see inline comment).

opencodejr

My earlier request is addressed: the test is now cut down to the core cases (an explicit traceparent set directly, one set by middleware, both without b3, and normal propagation when there is none). It still fails on the base branch and passes with this change, and typecheck:tsc is clean. The fix itself is unchanged and the public API is unchanged. Nothing else to raise.

opencodejr

This push is a rebase onto newer dev; the fix and test are unchanged. On the rebased code, test/executor.test.ts passes and typecheck:tsc is clean. The public API is unchanged. Nothing new to raise.

opencodejr

This push is another rebase onto newer dev; the fix and test are unchanged. On the rebased code, test/executor.test.ts passes and typecheck:tsc is clean. The public API is unchanged. Nothing new to raise.

opencodejr

This push merges dev into the branch; the fix and test are unchanged. On the merged code, test/executor.test.ts passes and typecheck:tsc is clean. The public API is unchanged. Nothing new to raise.

opencodejr

This push merges dev into the branch again; the fix and test are unchanged. On the merged code, test/executor.test.ts passes and typecheck:tsc is clean. The public API is unchanged. Nothing new to raise.

opencodejr

This push rebases the branch onto latest dev; the fix and test are unchanged. On the rebased code, test/executor.test.ts passes and typecheck:tsc is clean. The public API is unchanged. Nothing new to raise.

opencodejr