Repository navigation
fix(app): identify permission actions without a curated description in the dock - #60740
Closed
joby-brentsmith wants to merge 1 commit into
Closed
joby-brentsmith wants to merge 1 commit into
joby-brentsmith wants to merge 1 commit into
Conversation
Contributor
|
Thanks for working on this and for the clear write-up! I think this duplicates an open pull request:
The one thing this PR adds is showing |
Author
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue for this PR
Closes #51519 (also covers the generic report in #50234; #59405 fixes only the
shellkeys, which this supersedes for unknown actions)Type of change
What does this PR do?
When an MCP tool asks for permission, the dock shows only "Permission required" and a bare
*— the action name is generated at runtime (<server>_<tool>), so thesettings.permissions.tool.<action>.descriptionlookup always misses and the description row is hidden. The request already carries the data needed to identify the ask; this renders it:github_create_issue→ "github create issue") when no curated description exists. Built-in actions are unchanged — they keep their curated keys.request.message(the permission evaluate hook can provide it) as a hint row.metadata.input(the MCP tool arguments, forwarded since fix(mcp): pass tool input as permission metadata #51062) as a scrollable mono block. Only the MCP wrapper setsmetadata.input, so this never appears for built-in tools.request.messageunder the prompt title. The TUI already had a "Call tool " fallback, so it was less broken, but it dropped the message.session-request-docks.spec.tspinning the readable action name, the message line and the rendered input JSON.How did you verify your code works?
bun typecheckclean inpackages/appandpackages/tui.Screenshots / recordings
Pending — will attach screenshots of the fixed card for an MCP ask (readable action name, server message, tool arguments instead of only
*).Checklist