Repository navigation
refactor(core): deliver image generation notices via the job service - #60708
Open
kitlangton wants to merge 1 commit into
Open
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image generation now delegates completion notices to the job service, deleting 32 net lines from
image-generate.ts.Passing
sessionIDtojobs.startletsJobformat and deliver<image>completion, failure, and cancellation notices directly, removingImageGenerateTool.notifyWhenDoneand its plugin-scoped watcher fiber.❌ Before
ImageGenerateToolpre-allocatednotificationID, forkednotifyWhenDonein the plugin scope, and formattedImageNoticeitself.✅ After
ImageGenerateToolpassessessionID: context.sessionIDtojobs.startand callsjobs.background(id);Jobhandles persistence, formatting, delivery, and cleanup.🟰 Behavior change: notices survive plugin/location reloads instead of depending on the plugin's scope; output format and metadata are unchanged.
📊 Numbers
packages/core/src/tool/plugin/image-generate.ts+2 −34(−32 net lines)Tests: all 15 tests in
tool-image-generate.test.tspass.👀 Read:
packages/core/src/tool/plugin/image-generate.tsaroundjobs.start. Everything else is deletion.🔍 Split 5 of 6 from #60495 · shrinks production code by 32 lines
Checks run
bun run --cwd packages/core typecheckbun --cwd packages/core test test/tool-image-generate.test.ts: 15 pass