Skip to content

fix(tui): prevent keybinds from executing when dialog is open - #6017

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
anntnzrb:fix/suspend-keybinds-when-dialog-open
Dec 23, 2025
Merged

rekram1-node merged 1 commit into
anomalyco:devfrom
anntnzrb:fix/suspend-keybinds-when-dialog-open

Conversation

@anntnzrb

Copy link
Copy Markdown
Contributor

Summary

  • Fixes keybinds (like Tab for agent cycling) executing in the background when a dialog/picker is open

Details

Added dialog.stack.length > 0 guard to the useKeyboard handler in init() to prevent registered command keybinds from firing when a dialog is open. This follows the same pattern already used in CommandProvider (line 102) and session/index.tsx (line 254).

Fixes #6016

@rekram1-node

Copy link
Copy Markdown
Collaborator

/review

@github-actions

Copy link
Copy Markdown
Contributor

lgtm

@rekram1-node
rekram1-node merged commit 86b9b7b into anomalyco:dev Dec 23, 2025
2 checks passed
Clouder0 added a commit to Clouder0/overcode that referenced this pull request Jan 4, 2026
Merged upstream dev changes into my_dev job system branch.

Conflicts resolved:
- sidebar.tsx: Combined job system UI with upstream TodoItem and MCP count helpers
- compaction.ts: Kept InvalidTool + added upstream prompt replacement feature
- retry.test.ts: Kept both test suites (socket error + ECONNRESET tests)

Upstream features merged:
- Prompt stashing (anomalyco#6021)
- Did you know tips (anomalyco#5982)
- MCP OAuth debug command (anomalyco#5980)
- Cloudflare AI Gateway (anomalyco#5174)
- Install CLI flags (anomalyco#5885)
- Windows CRLF grep fix (anomalyco#5948)
- Dialog keybind blocking fix (anomalyco#6017)
- Model filtering fix (anomalyco#6053)
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
meSingh pushed a commit to meSingh/opencode that referenced this pull request Sep 6, 2026
androidand pushed a commit to androidand/opencode-skein that referenced this pull request Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Keybinds execute in background when dialogs/pickers are open

2 participants