Repository navigation
chore(deps): bump hono to 4.13.13 - #60022
Merged
Merged
Conversation
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The bump looks sound. Only packages/function (the API and share workers) depends on hono. On the base (4.10.7) and with this PR (4.13.13), I sent the same requests through app.fetch to every route on both workers, plus unknown paths and missing or invalid auth. Statuses, content types and bodies were identical. bun test passes (7/7), and the only type error is the missing bun:test types in a test file this PR doesn't touch.
The public API is unchanged: this is an internal dependency of private workers.
88 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped hono from 4.10.7 to 4.13.13 in the root
workspaces.catalog. packages/function (the API and share workers) is the only package that uses it, and nothing else pins hono or any@hono/*package. The lockfile change is just the hono entry.I went through the release notes from 4.10.8 to 4.13.13. Nothing changes the APIs these workers use (
get/post/delete/allrouting,c.text,c.json,c.html,c.req.header,c.req.json,c.req.url). Thec.jsonfast path added in 4.12.0 was reverted in 4.12.2. Thehono/<adapter>imports that 4.13.10 deprecated aren't used here.Verification
bun install --frozen-lockfileandbun install --minimum-release-age=604800: no changesbun check --no-scriptin packages/function: 1 error, the existing missingbun:testtypes error intest/github.test.ts. It's the same on origin/dev.bun testin packages/function: 7 pass, 0 failapp.fetchon both workers with 15 requests (every route, plus unknown paths, HEAD, OPTIONS, a missing or invalid Authorization header and an invalid JSON body), once on 4.10.7 and once on 4.13.13. Status codes, headers and bodies were identical.bunx wrangler dev --localforsrc/api.tsandsrc/share.ts, then curl against each route: same statuses and bodies as above (200/401/403/404 on the API worker, 200/200/200/410 on the share worker)