Repository navigation
fix(desktop): regenerate macOS icon sizes without edge halo - #59900
Merged
Merged
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
October 28, 2026 13:02
Brendonovich
enabled auto-merge (squash)
October 28, 2026 13:03
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks sound. I couldn't render it on macOS, so I decoded the .icns and dock.png files directly for all three channels and compared base and PR.
- The chunk layout and order, the 1024px
ic10image and theinfochunk are unchanged, and every smaller size, including the RLEic04/ic05, decodes at the right dimensions. - Against a premultiplied downsample of the 1024px image, the prod 64px edge pixels on the base are much too light (average brightness about 161 against about 19 expected). With this PR they are about 24, and all sizes from 16px to 128px now track the 1024px image closely in every channel.
dock.pngmatches the new 256px image in each channel.
Public API is unchanged: this only touches app icon assets and the icons README.
1 task done
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates every size below 1024px in the macOS
icon.icnsfor prod, beta and dev from that channel's existing 1024px image, and resyncsdock.png. The 1024px artwork, the chunk layout and theinfoentry are unchanged.Why
The smaller sizes from Image2Icon had unpremultiplied anti-aliased edges, so the semi-transparent pixels on the rounded outline were near-white instead of the icon's own colour. macOS uses the 64px size (
icon_32x32@2x) in System Settings lists, so the prod icon shows a light ring with jagged corners on dark backgrounds that other apps don't have.Measured against a premultiplied downsample of the same 1024px image, edge pixels that differ by more than 60 in any channel:
How
Each size is a premultiplied-alpha Lanczos downsample of the channel's 1024px image. The legacy
ic04/ic05ARGB sizes were re-encoded with the same RLE format.dock.pngequals the new 256px image, as the README requires. The README now notes that the smaller sizes must be generated this way.Verification
.icnsfiles decodes byte-identical to the expected downsample, and the 1024px size is byte-identical todev.iconutil -c iconseton macOS unpacks all ten sizes for all three channels.Requested by: @Brendonovich (Brendan via Slack)