Repository navigation
Conversation
|
Ready for review after local verification: 13 auth regressions, CLI typecheck, changed-file lint, and an isolated CLI/server smoke passed. The new CI workflows report |
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
Works as described. I ran opencode auth list from source against a mock server returning two credentials with the same label: on the base they print as identical rows, and with this change they show distinct IDs, with - for the environment connection. test/auth.test.ts passes and tsc -b is clean.
Public API: the default text output of opencode auth list gains a fourth column (credential ID, or -). --format json is unchanged, as are all flags and commands. Scripts that parse the table by splitting on whitespace will see an extra field; the JSON output is the stable interface for those.
One thing worth fixing before merge: the rewritten test drops an existing check that is unrelated to this feature (see inline comment).
There was a problem hiding this comment.
The earlier point is fixed: the test again passes requests to authServer and checks that /api/model/default is requested before /api/integration. Running the JSON and table commands one after the other keeps that check about the JSON run only. test/auth.test.ts passes and tsc -b is clean. Public API: unchanged since the last review (the default opencode auth list table gains a credential ID column; JSON output is unchanged). No new concerns.
There was a problem hiding this comment.
The merge with current dev keeps the earlier ordering point covered: the test now checks that /api/plugin is requested before /api/integration, matching loadIntegrations on dev. The docs edit moved to services/site, and list.ts is unchanged. Re-checked with auth list from source against a mock server (base shows identical same-label rows; this PR shows distinct credential IDs and - for env connections). test/auth.test.ts passes and tsc -b is clean. Public API: unchanged since the last review (the default opencode auth list table gains a credential ID column; JSON output is unchanged). No new concerns.
Issue for this PR
Closes #59040
Design approval requested on the issue; still pending. Implementation prepared with OpenAI Codex assistance.
Type of change
What does this PR do?
Append stable credential IDs to the auth table so same-label stored accounts are distinguishable. JSON output and environment connection handling remain intact.
How did you verify your code works?
Updated against upstream dev
06aa6da22eind89823b7d7. Upstream readiness now uses/api/plugin; the regression retains the readiness-before-integration ordering check with an active-plugin fixture. Feature docs follow the upstream move toservices/site.packages/cli: bun test --timeout 30000 test/auth.test.ts: 13 passed, 82 assertions. These spawn the actual CLI and cover distinct stored IDs, unchanged JSON, and the environment-row.packages/cli: bun run typecheck:tsc: passed.The installed Bun 1.4.3 cannot run the new
--no-scripttypecheck flag, so focused typechecks used the repository's pinned official compiler. The mandatory pre-pushbun run checkthen passed with Bun 1.4.4: lint completed (unrelated warnings remain) and 34/34 typecheck tasks succeeded.Screenshots / recordings
Plain CLI output change; verified through command output.
Checklist
Added by the opencode bot (AI-generated).
Public API: adds a credential ID column to the default
opencode auth listtable output (JSON output unchanged)Visual