Skip to content

fix: handle Windows CRLF line endings in grep tool - #5948

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
majiayu000:fix/5946-windows-crlf-grep
Dec 23, 2025
Merged

rekram1-node merged 1 commit into
anomalyco:devfrom
majiayu000:fix/5946-windows-crlf-grep

Conversation

@majiayu000

Copy link
Copy Markdown
Contributor

Summary

  • Uses regex /\r?\n/ to split lines, handling both Unix and Windows line endings
  • Fixes issue where ripgrep output on Windows includes CRLF, causing path parsing failures

Fixes #5946

Fixes #5946

Use regex /\r?\n/ instead of "\n" to split lines, correctly handling
both Unix (\n) and Windows (\r\n) line endings in ripgrep output.

Co-Authored-By: Claude <[email protected]>
@rekram1-node

Copy link
Copy Markdown
Collaborator

/review

@github-actions

Copy link
Copy Markdown
Contributor

lgtm

@rekram1-node
rekram1-node merged commit 5af3511 into anomalyco:dev Dec 23, 2025
2 checks passed
@majiayu000
majiayu000 deleted the fix/5946-windows-crlf-grep branch December 23, 2025 06:14
rekram1-node pushed a commit that referenced this pull request Dec 27, 2025
Clouder0 added a commit to Clouder0/overcode that referenced this pull request Jan 4, 2026
Merged upstream dev changes into my_dev job system branch.

Conflicts resolved:
- sidebar.tsx: Combined job system UI with upstream TodoItem and MCP count helpers
- compaction.ts: Kept InvalidTool + added upstream prompt replacement feature
- retry.test.ts: Kept both test suites (socket error + ECONNRESET tests)

Upstream features merged:
- Prompt stashing (anomalyco#6021)
- Did you know tips (anomalyco#5982)
- MCP OAuth debug command (anomalyco#5980)
- Cloudflare AI Gateway (anomalyco#5174)
- Install CLI flags (anomalyco#5885)
- Windows CRLF grep fix (anomalyco#5948)
- Dialog keybind blocking fix (anomalyco#6017)
- Model filtering fix (anomalyco#6053)
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
meSingh pushed a commit to meSingh/opencode that referenced this pull request Sep 6, 2026
androidand pushed a commit to androidand/opencode-skein that referenced this pull request Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grep tool fails on Windows: CRLF line ending not stripped from ripgrep path

2 participants