fix(desktop): finish the macOS Cmd+Q quit after shutdown - #59144

Issue for this PR

Closes #56394
Supersedes #58949 (builds on @anmol0b's diagnosis and deferred re-quit there).

Type of change

• Bug fix

What does this PR do?

On macOS, keyboard Cmd+Q closes the window but leaves the main process running. Reopening from the Dock then builds a window on a process whose shutdown has already run, and it stays on the loading splash.

Electron's Browser::Quit() runs is_quitting_ = HandleBeforeQuit(), so it records our preventDefault() only after before-quit returns. When no extension host has loaded, shutdown.run finishes in a microtask, and the re-issued app.quit() runs while the first emit is still on the stack. The nested quit starts closing windows, then the outer call writes is_quitting_ = false over it. When the last window closes, Electron emits window-all-closed instead of will-quit, which is a no-op on macOS.

Changes in lifecycle/index.ts:

• Defer the re-quit with setImmediate so the cancelled quit has finished unwinding before the new one starts. app.exit isn't used because it skips will-quit/quit, which electron-updater's install-on-quit depends on.
• Backstop in window-all-closed: once before-quit has fired, quit on macOS too. A quit that Electron drops for any reason still finishes instead of leaving a windowless process. The flag is set in before-quit, so autoUpdater.quitAndInstall (which closes windows before emitting before-quit) is unaffected.
• Don't restore windows in activate after a quit was requested, so the Dock never opens a window on torn-down services.
• Cap prepareToRestart at 10s, so a hung shutdown step can't leave every quit waiting forever.

Also renames makeMainWindows, makeWindowRecovery and makeUnresponsiveSampler to mainWindows, windowRecovery and unresponsiveSampler. lint:changed checks whole touched files, and no-service-constructor-imports flags any relative make[A-Z] import, so each of these fails the check once its importing file is edited.

How did you verify your code works?

• bun typecheck and bun run typecheck:tsc in packages/desktop.
• bun run lint:changed: clean.
• Not run on macOS from this branch. The deferred re-quit is the change that fix(desktop): finish the macOS Cmd+Q quit after shutdown #58949 verified with keyboard Cmd+Q (3/3 exits); the backstop and activate guard only take effect when a quit is dropped.

Requested by: @Brendonovich (Brendan via Slack)