Repository navigation
fix(app): drop model details tooltip from the composer model chip - #59108
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
The change looks correct. Removing the openDelay={750} override means the composer model tooltip now uses the shared Tooltip default (openDelay={400}, with skipDelayDuration={300} unchanged), set in packages/ui/src/overlays/tooltip/tooltip.tsx. I checked this by reading the code; I didn't run it, because hover timing in the web app needs a browser.
Public API: unchanged.
No concerns.
aaf1bf1 to
ce2234e
Compare
opencode-agent
Bot
changed the title
There was a problem hiding this comment.
The earlier review had no open points. The new commits look correct: the chip tooltip is now always the plain title + keybind, and the code that is no longer needed was removed cleanly (ModelDetails and createModelUsage are still used by the model picker). tsc --noEmit passes in packages/app. I didn't run the Playwright specs or look at the tooltip in a browser, so before/after screenshots of hovering the chip would help reviewers.
Public API: unchanged.
Minor: in composer.spec.ts, the new chip-text checks (toContainText("Console Model") and not.toContainText("Anomaly")) check very little, because the chip never shows the workspace name. They can be dropped to keep the test focused on the picker menu.
…omalyco#59108) Co-authored-by: jayair <[email protected]> Co-authored-by: Kit Langton <[email protected]> Co-authored-by: usrnk1 <[email protected]>
Summary
Choose model ⌘'tooltip as its neighbouring composer controls, with the shared default tooltip delay (this also drops the 750 ms override from fix(app): match model tooltip delay to tab previews #58056).Verification
bun run typecheckinpackages/apppasses.Requested by: @jayair (Jay via Slack)