Skip to content

ci: name workflows by kind (check-*, bot-*, triage-*) - #59077

Merged
thdxr merged 1 commit into
devfrom
rename-workflows
Oct 25, 2026
Merged

thdxr merged 1 commit into
devfrom
rename-workflows

Conversation

@thdxr

@thdxr thdxr commented Oct 25, 2026

Copy link
Copy Markdown
Member

Renames workflow files so their purpose is clear from the name. Job names are unchanged, so the required status checks on dev (unit, e2e, typecheck) keep working.

Before After
test.yml, storybook.yml, nix-eval.yml check-test.yml, check-storybook.yml, check-nix.yml
nix-hashes.yml, docs-locale-sync.yml bot-nix-hashes.yml, bot-docs-locale.yml
pr-management.yml, pr-standards.yml, compliance-close.yml, close-issues.yml, close-prs.yml triage-contributor.yml, triage-pr-standards.yml, triage-compliance-close.yml, triage-close-issues.yml, triage-close-prs.yml

check.yml keeps its name. publish.yml → release.yml happens in #59046.

@thdxr
thdxr enabled auto-merge (squash) October 25, 2026 22:32

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renames look right. Only the top-level name: and the self-referencing paths: filters change, and job names stay the same, so the required unit / e2e / typecheck checks are unaffected. I checked this by reading the diff and searching the repo for the old names. Public API is unchanged (CI only).

One regression: turbo.json still lists .github/workflows/test.yml in globalDependencies. That entry makes a change to the test workflow count as affecting every package, so bun turbo test --affected and the e2e turbo ls --affected step run everything. After the rename the path matches nothing. A future PR that only edits check-test.yml would then run on cached results and few or no tests. Please update it to .github/workflows/check-test.yml.

Minor: .opencode/skills/{unit-tests,tui-tests,app-e2e-tests,component-tests}/SKILL.md and packages/storybook/playwright/README.md still point at test.yml. That includes gh run list --workflow test.yml, which will stop working after the rename. It would be worth updating these here too.

@thdxr
thdxr merged commit 7b5b7a8 into dev Oct 25, 2026
21 checks passed
@thdxr
thdxr deleted the rename-workflows branch October 25, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant