Repository navigation
feat(session-ui): add a copy button to shell output - #58974
Merged
Merged
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
October 25, 2026 12:24
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
The change works as described and looks sound. I ran the shell, mobile, lifecycle and tool-group component specs against Storybook (39/39 pass, including the new copy test). tsc -b passes for packages/session-ui; its typecheck script couldn't run here because this Bun has no bun check. In the expanded-shell story the card at rest matches dev; on hover it shows a second copy button on the output, and that button stays pinned while a long output scrolls.
Public API: unchanged. The only addition is the ui.message.copyOutput UI string; other locales fall back through their Partial dictionaries.
No blocking concerns.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded shell and Code Mode execute cards now have a copy button on the output as well as the command.
<pre>, not inside it, so selecting text and copying by hand doesn't pick them up.devpixel for pixel; the only change is the new icon on hover. This is checked at 1376×464 (shell) and 1376×344 (execute) at 2x.Tests
bash-prenow targetbash-result, because each section has its own<pre>.bun typecheck(session-ui) passes. Component specssession-shell,session-timeline-mobile,session-lifecycle,tool-groupandsession-timelinepass, 46 tests. These ran locally against a warm Storybook, not cold.Before/after screenshots are in the Slack thread (GitHub attachment upload isn't available to the bot).
Requested by: @vimtor (victor via Slack)